cc/surfaces/surface_hittest_unittest.cc - Issue 1996783002: Make cc::SurfaceId unguessable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/surfaces/surface_hittest_unittest.cc

Issue 1996783002: Make cc::SurfaceId unguessable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed unit tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/surfaces/surface_hittest_unittest.cc

diff --git a/cc/surfaces/surface_hittest_unittest.cc b/cc/surfaces/surface_hittest_unittest.cc

index fec650942217c5a4a88b853e90fce9a92aca95b3..b6d279489ebbe71eb16d2634ebc889f77956c520 100644

--- a/cc/surfaces/surface_hittest_unittest.cc

+++ b/cc/surfaces/surface_hittest_unittest.cc

@@ -70,9 +70,7 @@ TEST(SurfaceHittestTest, Hittest_BadCompositorFrameDoesNotCrash) {

CreateCompositorFrame(root_rect, &root_pass);

// Add a reference to a non-existant child surface on the root surface.

- SurfaceIdAllocator child_allocator(3);

- SurfaceId child_surface_id;

- child_surface_id.id = 0xdeadbeef;

+ SurfaceId child_surface_id(3, 0, 0xdeadbeef);

gfx::Rect child_rect(200, 200);

CreateSurfaceDrawQuad(root_pass,

gfx::Transform(),