Make cc::SurfaceId unguessable

cc/surfaces/display_scheduler_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/surfaces/display_scheduler.h"
 
 #include "base/logging.h"
 #include "base/test/null_task_runner.h"
 #include "base/test/simple_test_tick_clock.h"
 #include "base/trace_event/trace_event.h"
@@ skipping 90 matching lines @@
 
   FakeBeginFrameSource fake_begin_frame_source_;
 
   std::unique_ptr<base::SimpleTestTickClock> now_src_;
   scoped_refptr<base::NullTaskRunner> task_runner_;
   std::unique_ptr<FakeDisplaySchedulerClient> client_;
   std::unique_ptr<TestDisplayScheduler> scheduler_;
 };
 
 TEST_F(DisplaySchedulerTest, ResizeHasLateDeadlineUntilNewRootSurface) {
-  SurfaceId root_surface_id1(1);
-  SurfaceId root_surface_id2(2);
-  SurfaceId sid1(3);
+  SurfaceId root_surface_id1(0, 1, 0);
+  SurfaceId root_surface_id2(0, 2, 0);
+  SurfaceId sid1(0, 3, 0);
   base::TimeTicks late_deadline;
 
   // Go trough an initial BeginFrame cycle with the root surface.
   BeginFrameForTest();
   scheduler_->SetNewRootSurface(root_surface_id1);
   scheduler_->BeginFrameDeadlineForTest();
 
   // Resize on the next begin frame cycle should cause the deadline to wait
   // for a new root surface.
   late_deadline = now_src().NowTicks() + BeginFrameArgs::DefaultInterval();
@@ skipping 12 matching lines @@
   BeginFrameForTest();
   scheduler_->SurfaceDamaged(sid1);
   EXPECT_GT(late_deadline, scheduler_->DesiredBeginFrameDeadlineTimeForTest());
   scheduler_->SurfaceDamaged(root_surface_id2);
   EXPECT_GE(now_src().NowTicks(),
             scheduler_->DesiredBeginFrameDeadlineTimeForTest());
   scheduler_->BeginFrameDeadlineForTest();
 }
 
 TEST_F(DisplaySchedulerTest, ResizeHasLateDeadlineUntilDamagedSurface) {
-  SurfaceId root_surface_id(1);
-  SurfaceId sid1(2);
+  SurfaceId root_surface_id(0, 1, 0);
+  SurfaceId sid1(0, 2, 0);
   base::TimeTicks late_deadline;
 
   // Go trough an initial BeginFrame cycle with the root surface.
   BeginFrameForTest();
   scheduler_->SetNewRootSurface(root_surface_id);
   scheduler_->BeginFrameDeadlineForTest();
 
   // Resize on the next begin frame cycle should cause the deadline to wait
   // for a new root surface.
   late_deadline = now_src().NowTicks() + BeginFrameArgs::DefaultInterval();
@@ skipping 12 matching lines @@
   BeginFrameForTest();
   scheduler_->SurfaceDamaged(sid1);
   EXPECT_GT(late_deadline, scheduler_->DesiredBeginFrameDeadlineTimeForTest());
   scheduler_->SurfaceDamaged(root_surface_id);
   EXPECT_GE(now_src().NowTicks(),
             scheduler_->DesiredBeginFrameDeadlineTimeForTest());
   scheduler_->BeginFrameDeadlineForTest();
 }
 
 TEST_F(DisplaySchedulerTest, SurfaceDamaged) {
-  SurfaceId root_surface_id(0);
-  SurfaceId sid1(1);
-  SurfaceId sid2(2);
+  SurfaceId root_surface_id(0, 0, 0);
+  SurfaceId sid1(0, 1, 0);
+  SurfaceId sid2(0, 2, 0);
 
   // Set the root surface
   scheduler_->SetNewRootSurface(root_surface_id);
 
   // Get scheduler to detect surface 1 as active by drawing
   // two frames in a row with damage from surface 1.
   BeginFrameForTest();
   scheduler_->SurfaceDamaged(sid1);
   scheduler_->BeginFrameDeadlineForTest();
   BeginFrameForTest();
@@ skipping 41 matching lines @@
   BeginFrameForTest();
   EXPECT_LT(now_src().NowTicks(),
             scheduler_->DesiredBeginFrameDeadlineTimeForTest());
   scheduler_->SurfaceDamaged(root_surface_id);
   EXPECT_GE(now_src().NowTicks(),
             scheduler_->DesiredBeginFrameDeadlineTimeForTest());
   scheduler_->BeginFrameDeadlineForTest();
 }
 
 TEST_F(DisplaySchedulerTest, OutputSurfaceLost) {
-  SurfaceId root_surface_id(0);
-  SurfaceId sid1(1);
+  SurfaceId root_surface_id(0, 0, 0);
+  SurfaceId sid1(0, 1, 0);
 
   // Set the root surface
   scheduler_->SetNewRootSurface(root_surface_id);
 
   // DrawAndSwap normally.
   BeginFrameForTest();
   EXPECT_LT(now_src().NowTicks(),
             scheduler_->DesiredBeginFrameDeadlineTimeForTest());
   EXPECT_EQ(0, client_->draw_and_swap_count());
   scheduler_->SurfaceDamaged(sid1);
   scheduler_->BeginFrameDeadlineForTest();
   EXPECT_EQ(1, client_->draw_and_swap_count());
 
   // Deadline triggers immediately on OutputSurfaceLost.
   BeginFrameForTest();
   EXPECT_LT(now_src().NowTicks(),
             scheduler_->DesiredBeginFrameDeadlineTimeForTest());
   scheduler_->OutputSurfaceLost();
   EXPECT_GE(now_src().NowTicks(),
             scheduler_->DesiredBeginFrameDeadlineTimeForTest());
 
   // Deadline does not DrawAndSwap after OutputSurfaceLost.
   EXPECT_EQ(1, client_->draw_and_swap_count());
   scheduler_->SurfaceDamaged(sid1);
   scheduler_->BeginFrameDeadlineForTest();
   EXPECT_EQ(1, client_->draw_and_swap_count());
 }
 
 TEST_F(DisplaySchedulerTest, ResizeCausesSwap) {
-  SurfaceId root_surface_id(0);
-  SurfaceId sid1(1);
+  SurfaceId root_surface_id(0, 0, 0);
+  SurfaceId sid1(0, 1, 0);
 
   // Set the root surface
   scheduler_->SetNewRootSurface(root_surface_id);
 
   // DrawAndSwap normally.
   BeginFrameForTest();
   EXPECT_LT(now_src().NowTicks(),
             scheduler_->DesiredBeginFrameDeadlineTimeForTest());
   EXPECT_EQ(0, client_->draw_and_swap_count());
   scheduler_->SurfaceDamaged(sid1);
   scheduler_->BeginFrameDeadlineForTest();
   EXPECT_EQ(1, client_->draw_and_swap_count());
 
   scheduler_->DisplayResized();
   BeginFrameForTest();
   // DisplayResized should trigger a swap to happen.
   scheduler_->BeginFrameDeadlineForTest();
   EXPECT_EQ(2, client_->draw_and_swap_count());
 }
 
 TEST_F(DisplaySchedulerTest, RootSurfaceResourcesLocked) {
-  SurfaceId root_surface_id(0);
-  SurfaceId sid1(1);
+  SurfaceId root_surface_id(0, 0, 0);
+  SurfaceId sid1(0, 1, 0);
   base::TimeTicks late_deadline;
 
   // Set the root surface
   scheduler_->SetNewRootSurface(root_surface_id);
 
   // DrawAndSwap normally.
   BeginFrameForTest();
   EXPECT_LT(now_src().NowTicks(),
             scheduler_->DesiredBeginFrameDeadlineTimeForTest());
   EXPECT_EQ(0, client_->draw_and_swap_count());
@@ skipping 24 matching lines @@
   scheduler_->SurfaceDamaged(root_surface_id);
   EXPECT_EQ(base::TimeTicks(),
             scheduler_->DesiredBeginFrameDeadlineTimeForTest());
 
   EXPECT_EQ(1, client_->draw_and_swap_count());
   scheduler_->BeginFrameDeadlineForTest();
   EXPECT_EQ(2, client_->draw_and_swap_count());
 }
 
 TEST_F(DisplaySchedulerTest, DidSwapBuffers) {
-  SurfaceId root_surface_id(0);
-  SurfaceId sid1(1);
-  SurfaceId sid2(2);
+  SurfaceId root_surface_id(0, 0, 0);
+  SurfaceId sid1(0, 1, 0);
+  SurfaceId sid2(0, 2, 0);
 
   // Set the root surface
   scheduler_->SetNewRootSurface(root_surface_id);
 
   // Get scheduler to detect surface 1 and 2 as active.
   BeginFrameForTest();
   scheduler_->SurfaceDamaged(sid1);
   scheduler_->SurfaceDamaged(sid2);
   scheduler_->BeginFrameDeadlineForTest();
   BeginFrameForTest();
@@ skipping 42 matching lines @@
             base::TimeTicks());
   // Draw and swap now that we aren't throttled.
   EXPECT_EQ(3, client_->draw_and_swap_count());
   scheduler_->BeginFrameDeadlineForTest();
   EXPECT_EQ(4, client_->draw_and_swap_count());
 }
 
 // This test verfies that we try to reschedule the deadline
 // after any event that may change what deadline we want.
 TEST_F(DisplaySchedulerTest, ScheduleBeginFrameDeadline) {
-  SurfaceId root_surface_id(1);
-  SurfaceId sid1(2);
+  SurfaceId root_surface_id(0, 1, 0);
+  SurfaceId sid1(0, 2, 0);
   int count = 1;
   EXPECT_EQ(count++, scheduler_->scheduler_begin_frame_deadline_count());
 
   // Set the root surface
   scheduler_->SetNewRootSurface(root_surface_id);
   EXPECT_EQ(count++, scheduler_->scheduler_begin_frame_deadline_count());
 
   BeginFrameForTest();
   EXPECT_EQ(count++, scheduler_->scheduler_begin_frame_deadline_count());
 
@@ skipping 16 matching lines @@
 
   scheduler_->SetRootSurfaceResourcesLocked(true);
   EXPECT_EQ(count++, scheduler_->scheduler_begin_frame_deadline_count());
 
   scheduler_->OutputSurfaceLost();
   EXPECT_EQ(count++, scheduler_->scheduler_begin_frame_deadline_count());
 }
 
 }  // namespace
 }  // namespace cc