components/mus/public/interfaces/surface_id.mojom - Issue 1996783002: Make cc::SurfaceId unguessable

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/mus/public/interfaces/surface_id.mojom

Issue 1996783002: Make cc::SurfaceId unguessable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed unit tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module mus.mojom;	5 module mus.mojom;

6	6

7 // A surface ID is composed of two parts, a local part and a namespace. The	7 // A surface ID is composed of two parts, a local part and a namespace. The

8 // local part is allocated by the client using any scheme that avoids	8 // local part is allocated by the client using any scheme that avoids

9 // duplicates. The namespace is allocated by the service and will be different	9 // duplicates. The namespace is allocated by the service and will be different

10 // for each client (aka each connection to mojo.Surface).	10 // for each client (aka each connection to mojo.Surface).

11 //	11 //

12 // The special id_namespace value 0 is equivalent to the namespace of the	12 // The special id_namespace value 0 is equivalent to the namespace of the

13 // client. This can be used to create, destroy and submit frames to	13 // client. This can be used to create, destroy and submit frames to

14 // surfaces before learning the namespace and to reference other surfaces	14 // surfaces before learning the namespace and to reference other surfaces

15 // owned by the same client. The actual id namespace must be used to pass	15 // owned by the same client. The actual id namespace must be used to pass

16 // surface ids to other clients for them to reference.	16 // surface ids to other clients for them to reference.

17 struct SurfaceId {	17 struct SurfaceId {

18 uint32 local;

19 uint32 id_namespace;	18 uint32 id_namespace;

	19 uint64 nonce;
	Tom Sepez 2016/05/24 22:35:45 again, I'd flip these. Just because. again, I'd flip these. Just because. Fady Samuel 2016/05/25 00:04:29 Done. Show quoted text On 2016/05/24 22:35:45, Tom Sepez wrote: > again, I'd flip these. Just because. Done.
	20 uint32 local_id;

20 };	21 };

OLD	NEW

« cc/surfaces/surface_id_allocator.cc ('K') | « cc/surfaces/surface_unittest.cc ('k') | components/mus/ws/server_window_surface.cc » ('j') | no next file with comments »