Fix DesktopSessioAgent crash when handling nullptr OnCaptureCompleted callback.

Fix DesktopSessioAgent crash when handling nullptr OnCaptureCompleted callback.

When DesktopSessionAgent receives a nullptr DesktopFrame, it will send an empty SerializedDesktopFrame (with dimensions equal to zero) to DesktopSessionProxy, and DesktopSessionProxy will also send a nullptr DesktopFrame.

BUG=

Committed: https://crrev.com/68440da3c34d06a6b1c48ab866c5f3f21f270d6a
Cr-Commit-Position: refs/heads/master@{#396281}

[Hzj_jie, 2016-05-19 21:19:02]

Patchset #1 (id:1) has been deleted

[Hzj_jie, 2016-05-19 21:20:51]

zijiehe@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Hzj_jie, 2016-05-19 21:49:15]

Description was changed from

==========
Fix DesktopSessioAgent crash when handling nullptr OnCaptureCompleted callback.

BUG=
==========

to

==========
Fix DesktopSessioAgent crash when handling nullptr OnCaptureCompleted callback.

BUG=
==========

[Hzj_jie, 2016-05-19 21:49:15]

zijiehe@chromium.org changed reviewers:
- sergeyu@chromium.org

[Sergey Ulanov, 2016-05-19 22:23:51]

sergeyu@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Sergey Ulanov, 2016-05-19 22:23:52]

https://codereview.chromium.org/1996753002/diff/20001/remoting/host/desktop_s...
File remoting/host/desktop_session_agent.cc (right):

https://codereview.chromium.org/1996753002/diff/20001/remoting/host/desktop_s...
remoting/host/desktop_session_agent.cc:329: if (!frame) {
I don't think we can just ignore the error here. The network process will still
think that capture request is pending. I think you want to send
ChromotingDesktopNetworkMsg_CaptureCompleted message with an empty
serialized_frame here. Then update DesktopSessionProxy::OnCaptureCompleted() to
handle empty serialized_frame.

[Hzj_jie, 2016-05-20 00:11:15]

https://codereview.chromium.org/1996753002/diff/20001/remoting/host/desktop_s...
File remoting/host/desktop_session_agent.cc (right):

https://codereview.chromium.org/1996753002/diff/20001/remoting/host/desktop_s...
remoting/host/desktop_session_agent.cc:329: if (!frame) {
On 2016/05/19 22:23:52, Sergey Ulanov wrote:
> I don't think we can just ignore the error here. The network process will
still
> think that capture request is pending. I think you want to send
> ChromotingDesktopNetworkMsg_CaptureCompleted message with an empty
> serialized_frame here. Then update DesktopSessionProxy::OnCaptureCompleted()
to
> handle empty serialized_frame.

Yes, I paused this review because of the screen frozen. Both DesktopSessionAgent
and DesktopSessionProxy need to be changed. And I am currently trying, if it
works well, I will restart the review.

[Hzj_jie, 2016-05-20 00:27:16]

zijiehe@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Hzj_jie, 2016-05-20 00:39:06]

zijiehe@chromium.org changed reviewers:
- jamiewalch@chromium.org, sergeyu@chromium.org

[Hzj_jie, 2016-05-20 21:14:09]

Description was changed from

==========
Fix DesktopSessioAgent crash when handling nullptr OnCaptureCompleted callback.

BUG=
==========

to

==========
Fix DesktopSessioAgent crash when handling nullptr OnCaptureCompleted callback.

When DesktopSessionAgent receives a nullptr DesktopFrame, it will send an empty
SerializedDesktopFrame (with dimensions equal to zero) to DesktopSessionProxy,
and DesktopSessionProxy will also send a nullptr DesktopFrame.

BUG=
==========

[Hzj_jie, 2016-05-20 21:14:09]

zijiehe@chromium.org changed reviewers:
+ jamiewalch@chromium.org, sergeyu@chromium.org

[Hzj_jie, 2016-05-20 21:39:15]

This change is ready to be reviewed.

[Sergey Ulanov, 2016-05-26 12:20:10]

lgtm when my nit is addressed

https://codereview.chromium.org/1996753002/diff/60001/remoting/host/desktop_s...
File remoting/host/desktop_session_proxy.cc (right):

https://codereview.chromium.org/1996753002/diff/60001/remoting/host/desktop_s...
remoting/host/desktop_session_proxy.cc:477: --pending_capture_frame_requests_;
Move this out of the if block and remove duplicate line 499

[Hzj_jie, 2016-05-26 20:59:22]

https://codereview.chromium.org/1996753002/diff/60001/remoting/host/desktop_s...
File remoting/host/desktop_session_proxy.cc (right):

https://codereview.chromium.org/1996753002/diff/60001/remoting/host/desktop_s...
remoting/host/desktop_session_proxy.cc:477: --pending_capture_frame_requests_;
On 2016/05/26 12:20:10, Sergey Ulanov (OOO) wrote:
> Move this out of the if block and remove duplicate line 499

Done.

[Hzj_jie, 2016-05-26 21:00:08]

The CQ bit was checked by zijiehe@chromium.org

[Hzj_jie, 2016-05-26 21:00:09]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/1996753002/#ps80001
(title: "Share two --pending_capture_frame_requests_ calls")

[commit-bot: I haz the power, 2016-05-26 21:00:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1996753002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1996753002/80001

[commit-bot: I haz the power, 2016-05-26 21:06:51]

Description was changed from

==========
Fix DesktopSessioAgent crash when handling nullptr OnCaptureCompleted callback.

When DesktopSessionAgent receives a nullptr DesktopFrame, it will send an empty
SerializedDesktopFrame (with dimensions equal to zero) to DesktopSessionProxy,
and DesktopSessionProxy will also send a nullptr DesktopFrame.

BUG=
==========

to

==========
Fix DesktopSessioAgent crash when handling nullptr OnCaptureCompleted callback.

When DesktopSessionAgent receives a nullptr DesktopFrame, it will send an empty
SerializedDesktopFrame (with dimensions equal to zero) to DesktopSessionProxy,
and DesktopSessionProxy will also send a nullptr DesktopFrame.

BUG=
==========

[commit-bot: I haz the power, 2016-05-26 21:06:52]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-05-26 21:08:19]

Description was changed from

==========
Fix DesktopSessioAgent crash when handling nullptr OnCaptureCompleted callback.

When DesktopSessionAgent receives a nullptr DesktopFrame, it will send an empty
SerializedDesktopFrame (with dimensions equal to zero) to DesktopSessionProxy,
and DesktopSessionProxy will also send a nullptr DesktopFrame.

BUG=
==========

to

==========
Fix DesktopSessioAgent crash when handling nullptr OnCaptureCompleted callback.

When DesktopSessionAgent receives a nullptr DesktopFrame, it will send an empty
SerializedDesktopFrame (with dimensions equal to zero) to DesktopSessionProxy,
and DesktopSessionProxy will also send a nullptr DesktopFrame.

BUG=

Committed: https://crrev.com/68440da3c34d06a6b1c48ab866c5f3f21f270d6a
Cr-Commit-Position: refs/heads/master@{#396281}
==========

[commit-bot: I haz the power, 2016-05-26 21:08:20]

Patchset 4 (id:??) landed as
https://crrev.com/68440da3c34d06a6b1c48ab866c5f3f21f270d6a
Cr-Commit-Position: refs/heads/master@{#396281}