Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Unified Diff: tests/standalone/io/process_shell_test.dart

Issue 19967002: Remove uses of Path class from tests/standalone. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix windows error Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/io/process_shell_test.dart
diff --git a/tests/standalone/io/process_shell_test.dart b/tests/standalone/io/process_shell_test.dart
index 3d0f6a8525af77dc0043585e83fea435d6bce39d..e461a8d96b4488683031316fb099dc6a7230f09b 100644
--- a/tests/standalone/io/process_shell_test.dart
+++ b/tests/standalone/io/process_shell_test.dart
@@ -2,15 +2,15 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+import "package:path/path.dart";
import "dart:io";
import "dart:isolate";
void testRunShell() {
test(args) {
- var path = new Path(Platform.script);
- path = path.directoryPath.join(new Path("process_echo_util.dart"));
+ var path = join(dirname(Platform.script), "process_echo_util.dart");
Process.run(Platform.executable,
- [path.toString()]..addAll(args),
+ [path]..addAll(args),
runInShell: true)
.then((result) {
if (Platform.operatingSystem == "windows") {
@@ -43,8 +43,6 @@ void testRunShell() {
void testBadRunShell() {
test(exe, [args = const []]) {
- var path = new Path(Platform.script);
- path = path.directoryPath.join(new Path("process_echo_util.dart"));
Process.run(exe, args, runInShell: true)
.then((result) {
port.close();
« no previous file with comments | « tests/standalone/io/process_set_exit_code_test.dart ('k') | tests/standalone/io/raw_secure_server_closing_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698