Srcover for sprite blitters.

Srcover for sprite blitters.

In order for this code to run, the gDefaultProfileIsSRGB flag needs to be true.

min base     min exp    percent   name
5601856   4689911   0.837207  top25desk_espn.skp_1
3491515   3202806   0.917311  top25desk_facebook.skp_1
5110247   4865740   0.952154  top25desk_weather_com.skp_1
605445    585520    0.96709   top25desk_techcrunch_com.skp_1
1007151   986193    0.979191  top25desk_wikipedia__1_tab_.skp_1
5951286   5889979   0.989699  top25desk_sports_yahoo_com_.skp_1
2825583   2804853   0.992663  top25desk_plus_google_com_11003.skp_1
8839265   8823249   0.998188  top25desk_twitter.skp_1
4169125   4168882   0.999942  top25desk_docs___1_open_documen.skp_1
6615327   6620663   1.00081   top25desk_youtube_com.skp_1
4613903   4647583   1.0073    top25desk_wordpress.skp_1
2532280   2554154   1.00864   top25desk_ebay_com.skp_1
4015689   4063584   1.01193   top25desk_google_com__hl_en_q_b.skp_1
9427478   9579203   1.01609   top25desk_answers_yahoo_com.skp_1
7403901   7542770   1.01876   top25desk_booking_com.skp_1
12249953  12528353  1.02273   top25desk_google_com_search_q_c.skp_1
1078648   1111050   1.03004   top25desk_games_yahoo_com.skp_1
7232627   7481555   1.03442   top25desk_pinterest.skp_1
2996819   3112091   1.03846   top25desk_google_com_calendar_.skp_1
2181531   2271677   1.04132   top25desk_amazon_com.skp_1
925245    987545    1.06733   top25desk_blogger.skp_1
4143359   4442607   1.07222   top25desk_linkedin.skp_1
4370962   4744580   1.08548   top25desk_news_yahoo_com.skp_1
4284025   4735094   1.10529   top25desk_mail_google_com_mail_.skp_1

[mtklein] We measured the noise here to be [-5%, +8%], so most of these changes fall within the noise.  We manually confirmed the two above that noise window (yahoo and mail) are also noise... srcover_srgb_srgb() did not figure prominently in their profiles.  The espn and facebook improvements look real.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1996683003

Committed: https://skia.googlesource.com/skia/+/a62038c478be1d668b3a1cea6b6974ddb5d90281

[herb_g, 2016-05-19 21:52:37]

Description was changed from

==========
Srcover for sprite blitters.

BUG=skia:
==========

to

==========
Srcover for sprite blitters.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2016-05-20 15:37:53]

Simplify blitter chooser.

[herb_g, 2016-05-20 15:39:54]

Remove srgb default.

[herb_g, 2016-05-20 15:42:07]

Description was changed from

==========
Srcover for sprite blitters.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Srcover for sprite blitters.

In order for this code to run, the gDefaultProfileIsSRGB flag needs to be true.

Before:
1.15ms  1.09ms  1.05505     top25desk_games_yahoo_com.skp_1
2.96ms  2.6ms   1.13846     top25desk_plus_google_com_11003.skp_1
8.15ms  6.94ms  1.17435     top25desk_booking_com.skp_1
1.08ms  820µs   1.31707     top25desk_wikipedia__1_tab_.skp_1
980µs   658µs   1.48936     top25desk_blogger.skp_1
2.58ms  1.73ms  1.49133     top25desk_ebay_com.skp_1
2.28ms  1.48ms  1.54054     top25desk_amazon_com.skp_1
3.13ms  2ms     1.565       top25desk_google_com_calendar_.skp_1
8.25ms  5.27ms  1.56546     top25desk_pinterest.skp_1
6.01ms  3.81ms  1.57743     top25desk_espn.skp_1
3.87ms  2.41ms  1.60581     top25desk_facebook.skp_1
4.79ms  2.88ms  1.66319     top25desk_news_yahoo_com.skp_1
634µs   356µs   1.7809      top25desk_techcrunch_com.skp_1
4.73ms  2.56ms  1.84766     top25desk_mail_google_com_mail_.skp_1
9.88ms  5.27ms  1.87476     top25desk_answers_yahoo_com.skp_1
10.5ms  5.42ms  1.93727     top25desk_twitter.skp_1
5.5ms   2.79ms  1.97133     top25desk_weather_com.skp_1
6.9ms   3.38ms  2.04142     top25desk_sports_yahoo_com_.skp_1
7.54ms  3.66ms  2.06011     top25desk_youtube_com.skp_1
4.6ms   2.16ms  2.12963     top25desk_linkedin.skp_1
4.17ms  1.91ms  2.18325     top25desk_docs___1_open_documen.skp_1
4.17ms  1.74ms  2.39655     top25desk_google_com__hl_en_q_b.skp_1
12.9ms  4.74ms  2.72152     top25desk_google_com_search_q_c.skp_1
4.97ms  1.76ms  2.82386     top25desk_wordpress.skp_1

After:
1.06ms  1.06ms  1        top25desk_games_yahoo_com.skp_1
2.79ms  2.79ms  1        top25desk_plus_google_com_11003.skp_1
7.47ms  6.65ms  1.12331  top25desk_booking_com.skp_1
4.67ms  3.9ms   1.19744  top25desk_espn.skp_1
989µs   824µs   1.20024  top25desk_wikipedia__1_tab_.skp_1
2.55ms  1.97ms  1.29442  top25desk_ebay_com.skp_1
3.26ms  2.45ms  1.33061  top25desk_facebook.skp_1
7.55ms  5.31ms  1.42185  top25desk_pinterest.skp_1
2.27ms  1.59ms  1.42767  top25desk_amazon_com.skp_1
3.05ms  2.13ms  1.43192  top25desk_google_com_calendar_.skp_1
939µs   613µs   1.53181  top25desk_blogger.skp_1
4.62ms  2.97ms  1.55556  top25desk_news_yahoo_com.skp_1
9.07ms  5.7ms   1.59123  top25desk_twitter.skp_1
576µs   354µs   1.62712  top25desk_techcrunch_com.skp_1
4.49ms  2.64ms  1.70076  top25desk_mail_google_com_mail_.skp_1
6.13ms  3.47ms  1.76657  top25desk_sports_yahoo_com_.skp_1
6.74ms  3.79ms  1.77836  top25desk_youtube_com.skp_1
5.11ms  2.82ms  1.81206  top25desk_weather_com.skp_1
9.61ms  5.15ms  1.86602  top25desk_answers_yahoo_com.skp_1
4.4ms   2.26ms  1.9469   top25desk_linkedin.skp_1
4.22ms  1.93ms  2.18653  top25desk_docs___1_open_documen.skp_1
3.91ms  1.77ms  2.20904  top25desk_google_com__hl_en_q_b.skp_1
4.7ms   1.94ms  2.42268  top25desk_wordpress.skp_1
12.5ms  4.91ms  2.54582  top25desk_google_com_search_q_c.skp_1

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2016-05-20 15:42:07]

herb@google.com changed reviewers:
+ reed@google.com

[msarett, 2016-05-20 15:46:57]

msarett@google.com changed reviewers:
+ msarett@google.com

[msarett, 2016-05-20 15:46:58]

https://codereview.chromium.org/1996683003/diff/40001/src/core/SkBlitter_Spri...
File src/core/SkBlitter_Sprite.cpp (right):

https://codereview.chromium.org/1996683003/diff/40001/src/core/SkBlitter_Spri...
src/core/SkBlitter_Sprite.cpp:109: if (dst.info().profileType() !=
src.info().profileType()
Can you check the gDefaultProfileIsSRGB flag directly here?  Instead of relying
on SkCodec to check it for you?

I'd like to remove that logic from SkCodec.

[herb_g, 2016-05-20 16:13:53]

On 2016/05/20 15:46:58, msarett wrote:
>
https://codereview.chromium.org/1996683003/diff/40001/src/core/SkBlitter_Spri...
> File src/core/SkBlitter_Sprite.cpp (right):
> 
>
https://codereview.chromium.org/1996683003/diff/40001/src/core/SkBlitter_Spri...
> src/core/SkBlitter_Sprite.cpp:109: if (dst.info().profileType() !=
> src.info().profileType()
> Can you check the gDefaultProfileIsSRGB flag directly here?  Instead of
relying
> on SkCodec to check it for you?
> 
> I'd like to remove that logic from SkCodec.

Checking the flag here would not catch all the cases, and this would not be
correct. Bitmaps are created from many places (like the Picture shader) which
should be linear. I think that having it on codecs is sound because it is a
source of bitmaps where they should be marked with the color information. Since
SkProfileType is the only color info so far it seem appropriate.

[msarett, 2016-05-20 16:38:48]

On 2016/05/20 16:13:53, herb_g wrote:
> On 2016/05/20 15:46:58, msarett wrote:
> >
>
https://codereview.chromium.org/1996683003/diff/40001/src/core/SkBlitter_Spri...
> > File src/core/SkBlitter_Sprite.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1996683003/diff/40001/src/core/SkBlitter_Spri...
> > src/core/SkBlitter_Sprite.cpp:109: if (dst.info().profileType() !=
> > src.info().profileType()
> > Can you check the gDefaultProfileIsSRGB flag directly here?  Instead of
> relying
> > on SkCodec to check it for you?
> > 
> > I'd like to remove that logic from SkCodec.
> 
> Checking the flag here would not catch all the cases, and this would not be
> correct. Bitmaps are created from many places (like the Picture shader) which
> should be linear. I think that having it on codecs is sound because it is a
> source of bitmaps where they should be marked with the color information.
Since
> SkProfileType is the only color info so far it seem appropriate.

Good point about the other srcs.

I agree that, because codecs are the source of bitmaps, they should mark the
color information.  However, I'd like them to provide the correct color
information - rather than matching an arbitrary flag.  I'm hoping to start
providing the correct information and to disable the current strangeness. 
That's why I suggest not depending this enum.

[herb_g, 2016-05-20 21:14:38]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-20 21:14:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1996683003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1996683003/40001

[commit-bot: I haz the power, 2016-05-20 21:35:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 21:35:11]

Dry run: This issue passed the CQ dry run.

[herb_g, 2016-05-24 21:21:41]

Combine classes.

[herb_g, 2016-05-24 21:23:03]

Description was changed from

==========
Srcover for sprite blitters.

In order for this code to run, the gDefaultProfileIsSRGB flag needs to be true.

Before:
1.15ms  1.09ms  1.05505     top25desk_games_yahoo_com.skp_1
2.96ms  2.6ms   1.13846     top25desk_plus_google_com_11003.skp_1
8.15ms  6.94ms  1.17435     top25desk_booking_com.skp_1
1.08ms  820µs   1.31707     top25desk_wikipedia__1_tab_.skp_1
980µs   658µs   1.48936     top25desk_blogger.skp_1
2.58ms  1.73ms  1.49133     top25desk_ebay_com.skp_1
2.28ms  1.48ms  1.54054     top25desk_amazon_com.skp_1
3.13ms  2ms     1.565       top25desk_google_com_calendar_.skp_1
8.25ms  5.27ms  1.56546     top25desk_pinterest.skp_1
6.01ms  3.81ms  1.57743     top25desk_espn.skp_1
3.87ms  2.41ms  1.60581     top25desk_facebook.skp_1
4.79ms  2.88ms  1.66319     top25desk_news_yahoo_com.skp_1
634µs   356µs   1.7809      top25desk_techcrunch_com.skp_1
4.73ms  2.56ms  1.84766     top25desk_mail_google_com_mail_.skp_1
9.88ms  5.27ms  1.87476     top25desk_answers_yahoo_com.skp_1
10.5ms  5.42ms  1.93727     top25desk_twitter.skp_1
5.5ms   2.79ms  1.97133     top25desk_weather_com.skp_1
6.9ms   3.38ms  2.04142     top25desk_sports_yahoo_com_.skp_1
7.54ms  3.66ms  2.06011     top25desk_youtube_com.skp_1
4.6ms   2.16ms  2.12963     top25desk_linkedin.skp_1
4.17ms  1.91ms  2.18325     top25desk_docs___1_open_documen.skp_1
4.17ms  1.74ms  2.39655     top25desk_google_com__hl_en_q_b.skp_1
12.9ms  4.74ms  2.72152     top25desk_google_com_search_q_c.skp_1
4.97ms  1.76ms  2.82386     top25desk_wordpress.skp_1

After:
1.06ms  1.06ms  1        top25desk_games_yahoo_com.skp_1
2.79ms  2.79ms  1        top25desk_plus_google_com_11003.skp_1
7.47ms  6.65ms  1.12331  top25desk_booking_com.skp_1
4.67ms  3.9ms   1.19744  top25desk_espn.skp_1
989µs   824µs   1.20024  top25desk_wikipedia__1_tab_.skp_1
2.55ms  1.97ms  1.29442  top25desk_ebay_com.skp_1
3.26ms  2.45ms  1.33061  top25desk_facebook.skp_1
7.55ms  5.31ms  1.42185  top25desk_pinterest.skp_1
2.27ms  1.59ms  1.42767  top25desk_amazon_com.skp_1
3.05ms  2.13ms  1.43192  top25desk_google_com_calendar_.skp_1
939µs   613µs   1.53181  top25desk_blogger.skp_1
4.62ms  2.97ms  1.55556  top25desk_news_yahoo_com.skp_1
9.07ms  5.7ms   1.59123  top25desk_twitter.skp_1
576µs   354µs   1.62712  top25desk_techcrunch_com.skp_1
4.49ms  2.64ms  1.70076  top25desk_mail_google_com_mail_.skp_1
6.13ms  3.47ms  1.76657  top25desk_sports_yahoo_com_.skp_1
6.74ms  3.79ms  1.77836  top25desk_youtube_com.skp_1
5.11ms  2.82ms  1.81206  top25desk_weather_com.skp_1
9.61ms  5.15ms  1.86602  top25desk_answers_yahoo_com.skp_1
4.4ms   2.26ms  1.9469   top25desk_linkedin.skp_1
4.22ms  1.93ms  2.18653  top25desk_docs___1_open_documen.skp_1
3.91ms  1.77ms  2.20904  top25desk_google_com__hl_en_q_b.skp_1
4.7ms   1.94ms  2.42268  top25desk_wordpress.skp_1
12.5ms  4.91ms  2.54582  top25desk_google_com_search_q_c.skp_1

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Srcover for sprite blitters.

In order for this code to run, the gDefaultProfileIsSRGB flag needs to be true.

Before:
1.1ms   1.03ms  1.06796  top25desk_games_yahoo_com.skp_1
3.06ms  2.62ms  1.16794  top25desk_plus_google_com_11003.skp_1
1.02ms  816µs   1.25     top25desk_wikipedia__1_tab_.skp_1
7.99ms  6.3ms   1.26825  top25desk_booking_com.skp_1
2.29ms  1.5ms   1.52667  top25desk_amazon_com.skp_1
3.13ms  2.04ms  1.53431  top25desk_google_com_calendar_.skp_1
7.66ms  4.99ms  1.53507  top25desk_pinterest.skp_1
4.68ms  3ms     1.56     top25desk_news_yahoo_com.skp_1
5.93ms  3.72ms  1.59409  top25desk_espn.skp_1
2.57ms  1.61ms  1.59627  top25desk_ebay_com.skp_1
3.73ms  2.33ms  1.60086  top25desk_facebook.skp_1
998µs   621µs   1.60709  top25desk_blogger.skp_1
588µs   357µs   1.64706  top25desk_techcrunch_com.skp_1
4.5ms   2.63ms  1.71103  top25desk_mail_google_com_mail_.skp_1
9.44ms  5.34ms  1.76779  top25desk_twitter.skp_1
6.28ms  3.4ms   1.84706  top25desk_sports_yahoo_com_.skp_1
6.86ms  3.62ms  1.89503  top25desk_youtube_com.skp_1
5.19ms  2.69ms  1.92937  top25desk_weather_com.skp_1
4.48ms  2.16ms  2.07407  top25desk_linkedin.skp_1
10ms    4.71ms  2.12314  top25desk_answers_yahoo_com.skp_1
4.07ms  1.8ms   2.26111  top25desk_google_com__hl_en_q_b.skp_1
4.16ms  1.76ms  2.36364  top25desk_docs___1_open_documen.skp_1
12.5ms  4.69ms  2.66525  top25desk_google_com_search_q_c.skp_1
4.9ms   1.81ms  2.70718  top25desk_wordpress.skp_1

After:
1.08ms  1.03ms  1.04854     top25desk_games_yahoo_com.skp_1
2.96ms  2.62ms  1.12977     top25desk_plus_google_com_11003.skp_1
7.62ms  6.3ms   1.20952     top25desk_booking_com.skp_1
4.68ms  3.72ms  1.25806     top25desk_espn.skp_1
1.08ms  816µs   1.32353     top25desk_wikipedia__1_tab_.skp_1
3.3ms   2.33ms  1.41631     top25desk_facebook.skp_1
3.06ms  2.04ms  1.5         top25desk_google_com_calendar_.skp_1
947µs   621µs   1.52496     top25desk_blogger.skp_1
2.46ms  1.61ms  1.52795     top25desk_ebay_com.skp_1
2.3ms   1.5ms   1.53333     top25desk_amazon_com.skp_1
7.81ms  4.99ms  1.56513     top25desk_pinterest.skp_1
4.76ms  3ms     1.58667     top25desk_news_yahoo_com.skp_1
9.44ms  5.34ms  1.76779     top25desk_twitter.skp_1
6.29ms  3.4ms   1.85        top25desk_sports_yahoo_com_.skp_1
672µs   357µs   1.88235     top25desk_techcrunch_com.skp_1
7.03ms  3.62ms  1.94199     top25desk_youtube_com.skp_1
5.15ms  2.63ms  1.95817     top25desk_mail_google_com_mail_.skp_1
5.29ms  2.69ms  1.96654     top25desk_weather_com.skp_1
9.69ms  4.71ms  2.05732     top25desk_answers_yahoo_com.skp_1
4.63ms  2.16ms  2.14352     top25desk_linkedin.skp_1
3.98ms  1.8ms   2.21111     top25desk_google_com__hl_en_q_b.skp_1
3.98ms  1.76ms  2.26136     top25desk_docs___1_open_documen.skp_1
4.85ms  1.81ms  2.67956     top25desk_wordpress.skp_1
12.6ms  4.69ms  2.68657     top25desk_google_com_search_q_c.skp_1

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2016-05-24 21:23:23]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-24 21:23:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1996683003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1996683003/60001

[herb_g, 2016-05-24 21:25:57]

Remove spurious files.

[herb_g, 2016-05-24 21:26:19]

The CQ bit was checked by herb@google.com to run a CQ dry run

[herb_g, 2016-05-24 21:26:27]

PTAL

[commit-bot: I haz the power, 2016-05-24 21:26:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1996683003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1996683003/80001

[commit-bot: I haz the power, 2016-05-24 21:48:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 21:48:16]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-05-25 13:38:58]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-05-25 13:38:59]

I can't help but see neutral performance results here.  Some speedups, some
slowdowns, overall sum from 117.1ms -> 115.7ms... that's about 1% speedup.   Is
this meant to be a speed improvement, or perhaps a refactoring step towards some
other?

[herb_g, 2016-05-26 17:13:26]

Description was changed from

==========
Srcover for sprite blitters.

In order for this code to run, the gDefaultProfileIsSRGB flag needs to be true.

Before:
1.1ms   1.03ms  1.06796  top25desk_games_yahoo_com.skp_1
3.06ms  2.62ms  1.16794  top25desk_plus_google_com_11003.skp_1
1.02ms  816µs   1.25     top25desk_wikipedia__1_tab_.skp_1
7.99ms  6.3ms   1.26825  top25desk_booking_com.skp_1
2.29ms  1.5ms   1.52667  top25desk_amazon_com.skp_1
3.13ms  2.04ms  1.53431  top25desk_google_com_calendar_.skp_1
7.66ms  4.99ms  1.53507  top25desk_pinterest.skp_1
4.68ms  3ms     1.56     top25desk_news_yahoo_com.skp_1
5.93ms  3.72ms  1.59409  top25desk_espn.skp_1
2.57ms  1.61ms  1.59627  top25desk_ebay_com.skp_1
3.73ms  2.33ms  1.60086  top25desk_facebook.skp_1
998µs   621µs   1.60709  top25desk_blogger.skp_1
588µs   357µs   1.64706  top25desk_techcrunch_com.skp_1
4.5ms   2.63ms  1.71103  top25desk_mail_google_com_mail_.skp_1
9.44ms  5.34ms  1.76779  top25desk_twitter.skp_1
6.28ms  3.4ms   1.84706  top25desk_sports_yahoo_com_.skp_1
6.86ms  3.62ms  1.89503  top25desk_youtube_com.skp_1
5.19ms  2.69ms  1.92937  top25desk_weather_com.skp_1
4.48ms  2.16ms  2.07407  top25desk_linkedin.skp_1
10ms    4.71ms  2.12314  top25desk_answers_yahoo_com.skp_1
4.07ms  1.8ms   2.26111  top25desk_google_com__hl_en_q_b.skp_1
4.16ms  1.76ms  2.36364  top25desk_docs___1_open_documen.skp_1
12.5ms  4.69ms  2.66525  top25desk_google_com_search_q_c.skp_1
4.9ms   1.81ms  2.70718  top25desk_wordpress.skp_1

After:
1.08ms  1.03ms  1.04854     top25desk_games_yahoo_com.skp_1
2.96ms  2.62ms  1.12977     top25desk_plus_google_com_11003.skp_1
7.62ms  6.3ms   1.20952     top25desk_booking_com.skp_1
4.68ms  3.72ms  1.25806     top25desk_espn.skp_1
1.08ms  816µs   1.32353     top25desk_wikipedia__1_tab_.skp_1
3.3ms   2.33ms  1.41631     top25desk_facebook.skp_1
3.06ms  2.04ms  1.5         top25desk_google_com_calendar_.skp_1
947µs   621µs   1.52496     top25desk_blogger.skp_1
2.46ms  1.61ms  1.52795     top25desk_ebay_com.skp_1
2.3ms   1.5ms   1.53333     top25desk_amazon_com.skp_1
7.81ms  4.99ms  1.56513     top25desk_pinterest.skp_1
4.76ms  3ms     1.58667     top25desk_news_yahoo_com.skp_1
9.44ms  5.34ms  1.76779     top25desk_twitter.skp_1
6.29ms  3.4ms   1.85        top25desk_sports_yahoo_com_.skp_1
672µs   357µs   1.88235     top25desk_techcrunch_com.skp_1
7.03ms  3.62ms  1.94199     top25desk_youtube_com.skp_1
5.15ms  2.63ms  1.95817     top25desk_mail_google_com_mail_.skp_1
5.29ms  2.69ms  1.96654     top25desk_weather_com.skp_1
9.69ms  4.71ms  2.05732     top25desk_answers_yahoo_com.skp_1
4.63ms  2.16ms  2.14352     top25desk_linkedin.skp_1
3.98ms  1.8ms   2.21111     top25desk_google_com__hl_en_q_b.skp_1
3.98ms  1.76ms  2.26136     top25desk_docs___1_open_documen.skp_1
4.85ms  1.81ms  2.67956     top25desk_wordpress.skp_1
12.6ms  4.69ms  2.68657     top25desk_google_com_search_q_c.skp_1

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Srcover for sprite blitters.

In order for this code to run, the gDefaultProfileIsSRGB flag needs to be true.

min base     min exp    percent   name
5601856   4689911   0.837207  top25desk_espn.skp_1
3491515   3202806   0.917311  top25desk_facebook.skp_1
5110247   4865740   0.952154  top25desk_weather_com.skp_1
605445    585520    0.96709   top25desk_techcrunch_com.skp_1
1007151   986193    0.979191  top25desk_wikipedia__1_tab_.skp_1
5951286   5889979   0.989699  top25desk_sports_yahoo_com_.skp_1
2825583   2804853   0.992663  top25desk_plus_google_com_11003.skp_1
8839265   8823249   0.998188  top25desk_twitter.skp_1
4169125   4168882   0.999942  top25desk_docs___1_open_documen.skp_1
6615327   6620663   1.00081   top25desk_youtube_com.skp_1
4613903   4647583   1.0073    top25desk_wordpress.skp_1
2532280   2554154   1.00864   top25desk_ebay_com.skp_1
4015689   4063584   1.01193   top25desk_google_com__hl_en_q_b.skp_1
9427478   9579203   1.01609   top25desk_answers_yahoo_com.skp_1
7403901   7542770   1.01876   top25desk_booking_com.skp_1
12249953  12528353  1.02273   top25desk_google_com_search_q_c.skp_1
1078648   1111050   1.03004   top25desk_games_yahoo_com.skp_1
7232627   7481555   1.03442   top25desk_pinterest.skp_1
2996819   3112091   1.03846   top25desk_google_com_calendar_.skp_1
2181531   2271677   1.04132   top25desk_amazon_com.skp_1
925245    987545    1.06733   top25desk_blogger.skp_1
4143359   4442607   1.07222   top25desk_linkedin.skp_1
4370962   4744580   1.08548   top25desk_news_yahoo_com.skp_1
4284025   4735094   1.10529   top25desk_mail_google_com_mail_.skp_1


BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2016-05-26 17:27:28]

Description was changed from

==========
Srcover for sprite blitters.

In order for this code to run, the gDefaultProfileIsSRGB flag needs to be true.

min base     min exp    percent   name
5601856   4689911   0.837207  top25desk_espn.skp_1
3491515   3202806   0.917311  top25desk_facebook.skp_1
5110247   4865740   0.952154  top25desk_weather_com.skp_1
605445    585520    0.96709   top25desk_techcrunch_com.skp_1
1007151   986193    0.979191  top25desk_wikipedia__1_tab_.skp_1
5951286   5889979   0.989699  top25desk_sports_yahoo_com_.skp_1
2825583   2804853   0.992663  top25desk_plus_google_com_11003.skp_1
8839265   8823249   0.998188  top25desk_twitter.skp_1
4169125   4168882   0.999942  top25desk_docs___1_open_documen.skp_1
6615327   6620663   1.00081   top25desk_youtube_com.skp_1
4613903   4647583   1.0073    top25desk_wordpress.skp_1
2532280   2554154   1.00864   top25desk_ebay_com.skp_1
4015689   4063584   1.01193   top25desk_google_com__hl_en_q_b.skp_1
9427478   9579203   1.01609   top25desk_answers_yahoo_com.skp_1
7403901   7542770   1.01876   top25desk_booking_com.skp_1
12249953  12528353  1.02273   top25desk_google_com_search_q_c.skp_1
1078648   1111050   1.03004   top25desk_games_yahoo_com.skp_1
7232627   7481555   1.03442   top25desk_pinterest.skp_1
2996819   3112091   1.03846   top25desk_google_com_calendar_.skp_1
2181531   2271677   1.04132   top25desk_amazon_com.skp_1
925245    987545    1.06733   top25desk_blogger.skp_1
4143359   4442607   1.07222   top25desk_linkedin.skp_1
4370962   4744580   1.08548   top25desk_news_yahoo_com.skp_1
4284025   4735094   1.10529   top25desk_mail_google_com_mail_.skp_1


BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Srcover for sprite blitters.

In order for this code to run, the gDefaultProfileIsSRGB flag needs to be true.

min base     min exp    percent   name
5601856   4689911   0.837207  top25desk_espn.skp_1
3491515   3202806   0.917311  top25desk_facebook.skp_1
5110247   4865740   0.952154  top25desk_weather_com.skp_1
605445    585520    0.96709   top25desk_techcrunch_com.skp_1
1007151   986193    0.979191  top25desk_wikipedia__1_tab_.skp_1
5951286   5889979   0.989699  top25desk_sports_yahoo_com_.skp_1
2825583   2804853   0.992663  top25desk_plus_google_com_11003.skp_1
8839265   8823249   0.998188  top25desk_twitter.skp_1
4169125   4168882   0.999942  top25desk_docs___1_open_documen.skp_1
6615327   6620663   1.00081   top25desk_youtube_com.skp_1
4613903   4647583   1.0073    top25desk_wordpress.skp_1
2532280   2554154   1.00864   top25desk_ebay_com.skp_1
4015689   4063584   1.01193   top25desk_google_com__hl_en_q_b.skp_1
9427478   9579203   1.01609   top25desk_answers_yahoo_com.skp_1
7403901   7542770   1.01876   top25desk_booking_com.skp_1
12249953  12528353  1.02273   top25desk_google_com_search_q_c.skp_1
1078648   1111050   1.03004   top25desk_games_yahoo_com.skp_1
7232627   7481555   1.03442   top25desk_pinterest.skp_1
2996819   3112091   1.03846   top25desk_google_com_calendar_.skp_1
2181531   2271677   1.04132   top25desk_amazon_com.skp_1
925245    987545    1.06733   top25desk_blogger.skp_1
4143359   4442607   1.07222   top25desk_linkedin.skp_1
4370962   4744580   1.08548   top25desk_news_yahoo_com.skp_1
4284025   4735094   1.10529   top25desk_mail_google_com_mail_.skp_1

[mtklein] We measured the noise here to be [-5%, +8%], so most of these changes
fall within the noise.  We manually confirmed the two above that noise window
(yahoo and mail) are also noise... srcover_srgb_srgb() did not figure
prominently in their profiles.  The espn and facebook improvements look real.


BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2016-05-26 17:27:56]

lgtm

[herb_g, 2016-05-26 17:43:11]

The CQ bit was checked by herb@google.com

[commit-bot: I haz the power, 2016-05-26 17:43:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1996683003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1996683003/80001

[commit-bot: I haz the power, 2016-05-26 17:56:21]

Description was changed from

==========
Srcover for sprite blitters.

In order for this code to run, the gDefaultProfileIsSRGB flag needs to be true.

min base     min exp    percent   name
5601856   4689911   0.837207  top25desk_espn.skp_1
3491515   3202806   0.917311  top25desk_facebook.skp_1
5110247   4865740   0.952154  top25desk_weather_com.skp_1
605445    585520    0.96709   top25desk_techcrunch_com.skp_1
1007151   986193    0.979191  top25desk_wikipedia__1_tab_.skp_1
5951286   5889979   0.989699  top25desk_sports_yahoo_com_.skp_1
2825583   2804853   0.992663  top25desk_plus_google_com_11003.skp_1
8839265   8823249   0.998188  top25desk_twitter.skp_1
4169125   4168882   0.999942  top25desk_docs___1_open_documen.skp_1
6615327   6620663   1.00081   top25desk_youtube_com.skp_1
4613903   4647583   1.0073    top25desk_wordpress.skp_1
2532280   2554154   1.00864   top25desk_ebay_com.skp_1
4015689   4063584   1.01193   top25desk_google_com__hl_en_q_b.skp_1
9427478   9579203   1.01609   top25desk_answers_yahoo_com.skp_1
7403901   7542770   1.01876   top25desk_booking_com.skp_1
12249953  12528353  1.02273   top25desk_google_com_search_q_c.skp_1
1078648   1111050   1.03004   top25desk_games_yahoo_com.skp_1
7232627   7481555   1.03442   top25desk_pinterest.skp_1
2996819   3112091   1.03846   top25desk_google_com_calendar_.skp_1
2181531   2271677   1.04132   top25desk_amazon_com.skp_1
925245    987545    1.06733   top25desk_blogger.skp_1
4143359   4442607   1.07222   top25desk_linkedin.skp_1
4370962   4744580   1.08548   top25desk_news_yahoo_com.skp_1
4284025   4735094   1.10529   top25desk_mail_google_com_mail_.skp_1

[mtklein] We measured the noise here to be [-5%, +8%], so most of these changes
fall within the noise.  We manually confirmed the two above that noise window
(yahoo and mail) are also noise... srcover_srgb_srgb() did not figure
prominently in their profiles.  The espn and facebook improvements look real.


BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Srcover for sprite blitters.

In order for this code to run, the gDefaultProfileIsSRGB flag needs to be true.

min base     min exp    percent   name
5601856   4689911   0.837207  top25desk_espn.skp_1
3491515   3202806   0.917311  top25desk_facebook.skp_1
5110247   4865740   0.952154  top25desk_weather_com.skp_1
605445    585520    0.96709   top25desk_techcrunch_com.skp_1
1007151   986193    0.979191  top25desk_wikipedia__1_tab_.skp_1
5951286   5889979   0.989699  top25desk_sports_yahoo_com_.skp_1
2825583   2804853   0.992663  top25desk_plus_google_com_11003.skp_1
8839265   8823249   0.998188  top25desk_twitter.skp_1
4169125   4168882   0.999942  top25desk_docs___1_open_documen.skp_1
6615327   6620663   1.00081   top25desk_youtube_com.skp_1
4613903   4647583   1.0073    top25desk_wordpress.skp_1
2532280   2554154   1.00864   top25desk_ebay_com.skp_1
4015689   4063584   1.01193   top25desk_google_com__hl_en_q_b.skp_1
9427478   9579203   1.01609   top25desk_answers_yahoo_com.skp_1
7403901   7542770   1.01876   top25desk_booking_com.skp_1
12249953  12528353  1.02273   top25desk_google_com_search_q_c.skp_1
1078648   1111050   1.03004   top25desk_games_yahoo_com.skp_1
7232627   7481555   1.03442   top25desk_pinterest.skp_1
2996819   3112091   1.03846   top25desk_google_com_calendar_.skp_1
2181531   2271677   1.04132   top25desk_amazon_com.skp_1
925245    987545    1.06733   top25desk_blogger.skp_1
4143359   4442607   1.07222   top25desk_linkedin.skp_1
4370962   4744580   1.08548   top25desk_news_yahoo_com.skp_1
4284025   4735094   1.10529   top25desk_mail_google_com_mail_.skp_1

[mtklein] We measured the noise here to be [-5%, +8%], so most of these changes
fall within the noise.  We manually confirmed the two above that noise window
(yahoo and mail) are also noise... srcover_srgb_srgb() did not figure
prominently in their profiles.  The espn and facebook improvements look real.


BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a62038c478be1d668b3a1cea6b6974ddb5d90281
==========

[commit-bot: I haz the power, 2016-05-26 17:56:22]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/a62038c478be1d668b3a1cea6b6974ddb5d90281