Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2708)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/service_worker_apitest.cc

Issue 1996673002: Disable flaky ServiceWorkerPushMessagingTest.OnPush test on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/service_worker_apitest.cc
diff --git a/chrome/browser/extensions/service_worker_apitest.cc b/chrome/browser/extensions/service_worker_apitest.cc
index 912a371fd87f289296df58fc9359d05c3148c653..3ddfc9cfe29a67025a9c1f779c93fdd8b0829cf1 100644
--- a/chrome/browser/extensions/service_worker_apitest.cc
+++ b/chrome/browser/extensions/service_worker_apitest.cc
@@ -698,7 +698,8 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerTest,
}
// Flaky on ChromiumOS bots. http://crbug.com/612673
-#if defined(OS_CHROMEOS)
+// Flaky on Windows bots. http://crbug.com/612840
+#if defined(OS_CHROMEOS) || defined(OS_WIN)
#define MAYBE_OnPush DISABLED_OnPush
#else
#define MAYBE_OnPush OnPush
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698