Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 1996663002: 🐸 Reland of Check for 0-length files in ResourceExtractor (Closed)

Created:
4 years, 7 months ago by agrieve
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Check for 0-length files in ResourceExtractor Reason for reland: No longer using ZipFile. Hopefully this was the reason for the dirty memory. TBR=yfriedman@chromium.org,torne@chromium.org,wnwen@chromium.org,qyearsley@chromium.org BUG=606413, 607598 Committed: https://crrev.com/f17984d06c7a736aa2cf7aac3d8aa6dc2628ef9a Cr-Commit-Position: refs/heads/master@{#394866}

Patch Set 1 #

Patch Set 2 : use pi.lastUpdateTime rather than complicated zip hash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -70 lines) Patch
M base/android/java/src/org/chromium/base/ResourceExtractor.java View 1 7 chunks +26 lines, -70 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
agrieve
Created Reland of 🐸 Check for 0-length files in ResourceExtractor
4 years, 7 months ago (2016-05-19 18:32:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996663002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996663002/40001
4 years, 7 months ago (2016-05-19 18:57:19 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-19 21:17:20 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 21:19:08 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f17984d06c7a736aa2cf7aac3d8aa6dc2628ef9a
Cr-Commit-Position: refs/heads/master@{#394866}

Powered by Google App Engine
This is Rietveld 408576698