Remove CFX_DSPATemplate usage in CXFA_TextParser

Remove CFX_DSPATemplate usage in CXFA_TextParser

This CL changes the check to use std::binary_search instead of the custom
lookup method. The tag validation has been split out to a separate method
with unit tests added.

Committed: https://pdfium.googlesource.com/pdfium/+/c7600f99490f83e544e37feb77d3b9e8428b0f68

[dsinclair, 2016-05-19 16:20:14]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-05-19 16:20:15]

PTAL.

[Tom Sepez, 2016-05-19 16:37:10]

https://codereview.chromium.org/1996623002/diff/1/xfa/fxfa/app/xfa_textlayout...
File xfa/fxfa/app/xfa_textlayout.cpp (right):

https://codereview.chromium.org/1996623002/diff/1/xfa/fxfa/app/xfa_textlayout...
xfa/fxfa/app/xfa_textlayout.cpp:284: uint32_t dwHashCode =
FX_HashCode_GetW(wsName.AsStringC(), true);
nit: local only used once, not needed.

https://codereview.chromium.org/1996623002/diff/1/xfa/fxfa/app/xfa_textlayout...
xfa/fxfa/app/xfa_textlayout.cpp:285: static const int32_t s_iCount =
sizeof(s_XFATagName) / sizeof(uint32_t);
nit: FX_ArraySize, also maybe move this up two lines so that it immediately
follows the array whose bounds it describes.

https://codereview.chromium.org/1996623002/diff/1/xfa/fxfa/app/xfa_textlayout...
File xfa/fxfa/app/xfa_textlayout_unittest.cpp (right):

https://codereview.chromium.org/1996623002/diff/1/xfa/fxfa/app/xfa_textlayout...
xfa/fxfa/app/xfa_textlayout_unittest.cpp:20:
EXPECT_TRUE(parser.TagValidate(L"br"));
Need not hit every one, I'd like to see an ALL CAPs test, also something like
"xhtml" and "htmlx" with suffix/prefix extension

[dsinclair, 2016-05-19 17:50:47]

https://codereview.chromium.org/1996623002/diff/1/xfa/fxfa/app/xfa_textlayout...
File xfa/fxfa/app/xfa_textlayout.cpp (right):

https://codereview.chromium.org/1996623002/diff/1/xfa/fxfa/app/xfa_textlayout...
xfa/fxfa/app/xfa_textlayout.cpp:284: uint32_t dwHashCode =
FX_HashCode_GetW(wsName.AsStringC(), true);
On 2016/05/19 16:37:10, Tom Sepez wrote:
> nit: local only used once, not needed.

Done.

https://codereview.chromium.org/1996623002/diff/1/xfa/fxfa/app/xfa_textlayout...
xfa/fxfa/app/xfa_textlayout.cpp:285: static const int32_t s_iCount =
sizeof(s_XFATagName) / sizeof(uint32_t);
On 2016/05/19 16:37:10, Tom Sepez wrote:
> nit: FX_ArraySize, also maybe move this up two lines so that it immediately
> follows the array whose bounds it describes.

Done.

https://codereview.chromium.org/1996623002/diff/1/xfa/fxfa/app/xfa_textlayout...
File xfa/fxfa/app/xfa_textlayout_unittest.cpp (right):

https://codereview.chromium.org/1996623002/diff/1/xfa/fxfa/app/xfa_textlayout...
xfa/fxfa/app/xfa_textlayout_unittest.cpp:20:
EXPECT_TRUE(parser.TagValidate(L"br"));
On 2016/05/19 16:37:10, Tom Sepez wrote:
> Need not hit every one, I'd like to see an ALL CAPs test, also something like
> "xhtml" and "htmlx" with suffix/prefix extension

Done.

[Tom Sepez, 2016-05-19 21:12:03]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-05-19 21:12:04]

lgtm

[commit-bot: I haz the power, 2016-05-19 21:12:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1996623002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1996623002/20001

[commit-bot: I haz the power, 2016-05-19 21:12:35]

Description was changed from

==========
Remove CFX_DSPATemplate usage in CXFA_TextParser

This CL changes the check to use std::binary_search instead of the custom
lookup method. The tag validation has been split out to a separate method
with unit tests added.
==========

to

==========
Remove CFX_DSPATemplate usage in CXFA_TextParser

This CL changes the check to use std::binary_search instead of the custom
lookup method. The tag validation has been split out to a separate method
with unit tests added.

Committed:
https://pdfium.googlesource.com/pdfium/+/c7600f99490f83e544e37feb77d3b9e8428b...
==========

[commit-bot: I haz the power, 2016-05-19 21:12:36]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/c7600f99490f83e544e37feb77d3b9e8428b...