Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1996603003: Display origin for WebBluetooth and WebUSB chooser on Android (Closed)

Created:
4 years, 7 months ago by juncai
Modified:
4 years, 6 months ago
Reviewers:
Ted C
CC:
chromium-reviews, Jeffrey Yasskin, scheib
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Display origin for WebBluetooth and WebUSB chooser on Android This patch modified code to display origin instead of url on the chooser title that is used by WebBluetooth and WebUSB on Android. BUG=612953 Committed: https://crrev.com/1d2289e81db9763592d753a38f0be7227bff33be Cr-Commit-Position: refs/heads/master@{#396891}

Patch Set 1 : display origin for WebBluetooth and WebUSB chooser on Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/ui/android/bluetooth_chooser_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/usb_chooser_dialog_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
juncai
Please take a look.
4 years, 7 months ago (2016-05-19 17:41:01 UTC) #2
juncai
kindly ping, :).
4 years, 7 months ago (2016-05-24 03:49:51 UTC) #4
juncai
Please take a look.
4 years, 6 months ago (2016-05-31 17:46:37 UTC) #7
Ted C
lgtm
4 years, 6 months ago (2016-05-31 18:01:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996603003/1
4 years, 6 months ago (2016-05-31 18:05:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 19:22:40 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 19:24:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d2289e81db9763592d753a38f0be7227bff33be
Cr-Commit-Position: refs/heads/master@{#396891}

Powered by Google App Engine
This is Rietveld 408576698