Add ImeMenuTray element.

ash/shelf/shelf.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shelf/shelf.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "ash/aura/wm_window_aura.h"
 #include "ash/common/shelf/shelf_item_delegate.h"
 #include "ash/common/shelf/shelf_item_delegate_manager.h"
 #include "ash/common/shelf/shelf_model.h"
 #include "ash/common/shelf/wm_shelf_util.h"
 #include "ash/common/shell_window_ids.h"
 #include "ash/root_window_controller.h"
 #include "ash/screen_util.h"
 #include "ash/shelf/shelf_delegate.h"
 #include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shelf/shelf_navigator.h"
 #include "ash/shelf/shelf_util.h"
 #include "ash/shelf/shelf_view.h"
 #include "ash/shell.h"
 #include "ash/shell_delegate.h"
 #include "ash/wm/window_properties.h"
+#include "ui/aura/client/aura_constants.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_event_dispatcher.h"
 #include "ui/aura/window_observer.h"
 #include "ui/compositor/layer.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/image/image_skia_operations.h"
 #include "ui/gfx/skbitmap_operations.h"
 #include "ui/views/accessible_pane_view.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/widget/widget_delegate.h"
 #include "ui/wm/public/activation_client.h"
 
+#if defined(OS_CHROMEOS)
+#include "ash/system/chromeos/ime_menu/ime_menu_tray.h"
+#endif  // defined(OS_CHROMEOS)
+
 namespace ash {
 
 const char Shelf::kNativeViewName[] = "ShelfView";
 
 Shelf::Shelf(ShelfModel* shelf_model,
              ShelfDelegate* shelf_delegate,
              WmShelf* wm_shelf,
              ShelfWidget* shelf_widget)
     : delegate_(shelf_delegate),
       wm_shelf_(wm_shelf),
@@ skipping 59 matching lines @@
   return shelf_widget_->shelf_layout_manager()->auto_hide_state();
 }
 
 ShelfVisibilityState Shelf::GetVisibilityState() const {
   return shelf_widget_->shelf_layout_manager()->visibility_state();
 }
 
 gfx::Rect Shelf::GetScreenBoundsOfItemIconForWindow(
     const aura::Window* window) {
   ShelfID id = GetShelfIDForWindow(window);
-  gfx::Rect bounds(shelf_view_->GetIdealBoundsOfItemIcon(id));
-  gfx::Point screen_origin;
-  views::View::ConvertPointToScreen(shelf_view_, &screen_origin);
-  return gfx::Rect(screen_origin.x() + bounds.x(),
-                   screen_origin.y() + bounds.y(),
-                   bounds.width(),
+  gfx::Rect bounds;
+  int offset_x = 0;
+  int offset_y = 0;

[sadrul, 2016/06/27 15:08:05]

Use a gfx::Vector2d offset here instead.

[Azure Wei, 2016/06/27 18:33:48]

Done.

+#if defined(OS_CHROMEOS)
+  if (window->GetProperty(aura::client::kShowIconOnTrayKey)) {
+    // For opt-in IME menu, the item icon lays on the status tray.
+    bounds = shelf_widget_->status_area_widget()->ime_menu_tray()->bounds();

[sadrul, 2016/06/27 15:08:04]

It's not obvious at all that 'show icon on tray' means ime-menu item in the
tray. Can this be more obvious?

[Azure Wei, 2016/06/27 18:33:48]

Renamed as kShelfItemOnTrayForImeMenu. Is that better?

+    gfx::Rect status_area_bounds =
+        shelf_widget_->status_area_widget()->GetWindowBoundsInScreen();
+    offset_x = status_area_bounds.x();
+    offset_y = status_area_bounds.y();

[sadrul, 2016/06/27 15:08:04]

offset = status_area_bounds.OffsetFromOrigin();

[Azure Wei, 2016/06/27 18:33:48]

Done.

+  }
+#endif  // defined(OS_CHROMEOS)
+  if (!window->GetProperty(aura::client::kShowIconOnTrayKey)) {
+    bounds = (shelf_view_->GetIdealBoundsOfItemIcon(id));
+    gfx::Point screen_origin;
+    views::View::ConvertPointToScreen(shelf_view_, &screen_origin);
+    offset_x = screen_origin.x();
+    offset_y = screen_origin.y();
+  }
+
+  return gfx::Rect(offset_x + bounds.x(), offset_y + bounds.y(), bounds.width(),

[sadrul, 2016/06/27 15:08:04]

return bounds + offset;

[Azure Wei, 2016/06/27 18:33:48]

Done.

                    bounds.height());
 }
 
 void Shelf::UpdateIconPositionForWindow(aura::Window* window) {
   shelf_view_->UpdatePanelIconPosition(
       GetShelfIDForWindow(window),
       ScreenUtil::ConvertRectFromScreen(
           shelf_widget()->GetNativeView(),
           window->GetBoundsInScreen()).CenterPoint());
 }
@@ skipping 78 matching lines @@
 
 gfx::Rect Shelf::GetVisibleItemsBoundsInScreen() const {
   return shelf_view_->GetVisibleItemsBoundsInScreen();
 }
 
 app_list::ApplicationDragAndDropHost* Shelf::GetDragAndDropHostForAppList() {
   return shelf_view_;
 }
 
 }  // namespace ash