third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp - Issue 1996543002: Avoid using forced layout to trigger paint invalidation for SVG containers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

Issue 1996543002: Avoid using forced layout to trigger paint invalidation for SVG containers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.h ('K') | « third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.h ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.h » ('j') | third_party/WebKit/Source/platform/transforms/AffineTransform.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

index 334406103796d607d9cfbf31665fd4e693b1a070..df6cc47a10bcf3edd34da9c1ca64ab5220e33024 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

@@ -55,8 +55,9 @@ void LayoutSVGContainer::layout()

calcViewport();

// Allow LayoutSVGTransformableContainer to update its transform.

- bool updatedTransform = calculateLocalTransform();

- m_didScreenScaleFactorChange = updatedTransform || SVGLayoutSupport::screenScaleFactorChanged(parent());

+ unsigned updatedTransform = calculateLocalTransform();

+ m_didScreenScaleFactorChange =

+ (updatedTransform & ScaleChange) || SVGLayoutSupport::screenScaleFactorChanged(parent());

// LayoutSVGViewportContainer needs to set the 'layout size changed' flag.

determineIfLayoutSizeChanged();