third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp - Issue 1996543002: Avoid using forced layout to trigger paint invalidation for SVG containers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp

Issue 1996543002: Avoid using forced layout to trigger paint invalidation for SVG containers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TE updates Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.h ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGTransformableContainer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp

index 8653fca29ee23cd93a1483631f2a27e215eebe4c..9f4b1c1d7bcd26faef4a027d2a195ad6b06bc977 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp

@@ -153,12 +153,12 @@ void LayoutSVGResourceMarker::calcViewport()

m_viewport = FloatRect(0, 0, w, h);

}

-bool LayoutSVGResourceMarker::calculateLocalTransform()

+LayoutSVGContainer::TransformChange LayoutSVGResourceMarker::calculateLocalTransform()

{

// TODO(fs): Temporarily, needing a layout implies that the local transform

// has changed. This should be updated to be more precise and factor in the

// actual (relevant) changes to the computed user-space transform.

- return selfNeedsLayout();

+ return selfNeedsLayout() ? TransformChange::Full : TransformChange::None;

}

} // namespace blink