Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1996533004: Fix the Skia build after 9b1a0ee. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez, caryclark
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -97 lines) Patch
M core/fpdfapi/fpdf_page/fpdf_page_func.cpp View 10 chunks +53 lines, -38 lines 0 comments Download
M core/fpdfapi/fpdf_page/pageint.h View 6 chunks +27 lines, -3 lines 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 4 chunks +42 lines, -56 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Lei Zhang
4 years, 7 months ago (2016-05-19 23:40:06 UTC) #2
Tom Sepez
lgtm
4 years, 7 months ago (2016-05-20 00:11:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996533004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996533004/1
4 years, 7 months ago (2016-05-20 00:14:48 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 00:15:04 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/1f36fa860a170081f66809d634ec7ab83d7c...

Powered by Google App Engine
This is Rietveld 408576698