Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1996533003: Change framebuffer.clear to use background color (Closed)

Created:
4 years, 7 months ago by mit
Modified:
4 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
dartino-code-reviews_googlegroups.com
Base URL:
git@github.com:dartino/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

* Make clear use the background color * Update samples Fixes #503 R=sgjesse@google.com Committed: https://github.com/dartino/sdk/commit/2e70487d24d091ba7471d6d4c99a0c16abfd1196

Patch Set 1 : Initial upload #

Total comments: 2

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M pkg/stm32/lib/lcd.dart View 1 1 chunk +9 lines, -5 lines 0 comments Download
M samples/stm32f746g-discovery/disco-light.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/stm32f746g-discovery/touch.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/stm32f746g-discovery/turtle-graphics/turtle.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mit
Please review
4 years, 7 months ago (2016-05-19 12:40:52 UTC) #3
Søren Gjesse
lgtm https://codereview.chromium.org/1996533003/diff/1/pkg/stm32/lib/lcd.dart File pkg/stm32/lib/lcd.dart (right): https://codereview.chromium.org/1996533003/diff/1/pkg/stm32/lib/lcd.dart#newcode88 pkg/stm32/lib/lcd.dart:88: color = _backgroundColor; Just color ??= _backgrouncColor;
4 years, 7 months ago (2016-05-19 12:48:27 UTC) #4
mit
Thanks, feedback incorporated https://codereview.chromium.org/1996533003/diff/1/pkg/stm32/lib/lcd.dart File pkg/stm32/lib/lcd.dart (right): https://codereview.chromium.org/1996533003/diff/1/pkg/stm32/lib/lcd.dart#newcode88 pkg/stm32/lib/lcd.dart:88: color = _backgroundColor; On 2016/05/19 12:48:27, ...
4 years, 7 months ago (2016-05-19 12:54:38 UTC) #5
mit
4 years, 7 months ago (2016-05-19 12:54:56 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
2e70487d24d091ba7471d6d4c99a0c16abfd1196 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698