Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1996533002: Revert of Reland changes to v8_snapshot GN build arg. (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, stevenjb, hashimoto
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland changes to v8_snapshot GN build arg. (patchset #2 id:20001 of https://codereview.chromium.org/1979883002/ ) Reason for revert: Blocks the roll again: https://codereview.chromium.org/1993163002/ https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/140169 Lets add chromeos_amd64-generic_chromium_compile_only_ng on a reland as well. Original issue's description: > Reland changes to v8_snapshot GN build arg. > > This patch re-lands #36193 with a couple of minor tweaks > including updating the BUILD.gn file to use the new > variable name and incorporating thakis' request to support > cross-compiling the win snapshot from a mac. > > R=thakis@chromium.org, jochen@chromium.org, machenbach@chromium.org > BUG=608596, 595653 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng > > Committed: https://crrev.com/b6168e1223d266dba1a357a921bc84ae97a1d803 > Cr-Commit-Position: refs/heads/master@{#36342} TBR=jochen@chromium.org,thakis@chromium.org,stevenjb@chromium.org,adamk@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=608596, 595653 Committed: https://crrev.com/2c95b572cc2981df4b5315270deca151f093a46b Cr-Commit-Position: refs/heads/master@{#36347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -40 lines) Patch
M BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M snapshot_toolchain.gni View 1 chunk +11 lines, -36 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
Created Revert of Reland changes to v8_snapshot GN build arg.
4 years, 7 months ago (2016-05-19 07:10:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996533002/1
4 years, 7 months ago (2016-05-19 07:10:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 07:10:29 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2c95b572cc2981df4b5315270deca151f093a46b Cr-Commit-Position: refs/heads/master@{#36347}
4 years, 7 months ago (2016-05-19 07:11:45 UTC) #6
Dirk Pranke
4 years, 7 months ago (2016-05-19 15:10:57 UTC) #7
Message was sent while issue was closed.
On 2016/05/19 07:11:45, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/2c95b572cc2981df4b5315270deca151f093a46b
> Cr-Commit-Position: refs/heads/master@{#36347}

lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698