Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: tools/perf/metrics/loading.py

Issue 199653007: Rename and add more page loading metrics for Chrome Proxy tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/loading.py
diff --git a/tools/perf/metrics/loading.py b/tools/perf/metrics/loading.py
index c1d4360f31e77932527259f70602bae048438935..8495835396c0a9cc84cacba2bd9e062b5e0c9b87 100644
--- a/tools/perf/metrics/loading.py
+++ b/tools/perf/metrics/loading.py
@@ -15,12 +15,43 @@ class LoadingMetric(Metric):
def AddResults(self, tab, results):
load_timings = tab.EvaluateJavaScript('window.performance.timing')
- load_time_ms = (
- float(load_timings['loadEventStart']) -
- load_timings['navigationStart'])
- dom_content_loaded_time_ms = (
+
+ # NavigationStart relative markers in milliseconds.
+ load_start = (
+ float(load_timings['loadEventStart']) - load_timings['navigationStart'])
+ results.Add('load_start', 'ms', load_start)
+
+ dom_content_loaded_start = (
float(load_timings['domContentLoadedEventStart']) -
load_timings['navigationStart'])
- results.Add('load_time', 'ms', load_time_ms)
- results.Add('dom_content_loaded_time', 'ms',
- dom_content_loaded_time_ms)
+ results.Add('dom_content_loaded_start', 'ms', dom_content_loaded_start)
+
+ fetch_start = (
+ float(load_timings['fetchStart']) - load_timings['navigationStart'])
+ results.Add('fetch_start', 'ms', fetch_start, data_type='unimportant')
+
+ request_start = (
+ float(load_timings['requestStart']) - load_timings['navigationStart'])
+ results.Add('request_start', 'ms', request_start, data_type='unimportant')
+
+ # Phase measurements in milliseconds.
+ domain_lookup_duration = (
+ float(load_timings['domainLookupEnd']) -
+ load_timings['domainLookupStart'])
+ results.Add('domain_lookup_duration', 'ms', domain_lookup_duration,
+ data_type='unimportant')
+
+ connect_duration = (
+ float(load_timings['connectEnd']) - load_timings['connectStart'])
+ results.Add('connect_duration', 'ms', connect_duration,
+ data_type='unimportant')
+
+ request_duration = (
+ float(load_timings['responseStart']) - load_timings['requestStart'])
+ results.Add('request_duration', 'ms', request_duration,
+ data_type='unimportant')
+
+ response_duration = (
+ float(load_timings['responseEnd']) - load_timings['responseStart'])
+ results.Add('response_duration', 'ms', response_duration,
+ data_type='unimportant')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698