Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.cc

Issue 1996473002: Track age and score of snippets that are clicked (along with position). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: After code review #3 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/ntp/ntp_snippets_bridge.cc
diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.cc b/chrome/browser/android/ntp/ntp_snippets_bridge.cc
index 5e9e257a3544e37602e81a6182b113809d54629c..6f006fd80a7fc5c8b0af877601d5f9cf65c96c06 100644
--- a/chrome/browser/android/ntp/ntp_snippets_bridge.cc
+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.cc
@@ -28,6 +28,7 @@ using base::android::ConvertJavaStringToUTF8;
using base::android::JavaParamRef;
using base::android::ToJavaArrayOfStrings;
using base::android::ToJavaLongArray;
+using base::android::ToJavaFloatArray;
using base::android::ScopedJavaGlobalRef;
using base::android::ScopedJavaLocalRef;
@@ -135,6 +136,7 @@ void NTPSnippetsBridge::NTPSnippetsServiceLoaded() {
std::vector<std::string> snippets;
std::vector<int64_t> timestamps;
std::vector<std::string> publishers;
+ std::vector<float> scores;
for (const std::unique_ptr<ntp_snippets::NTPSnippet>& snippet :
ntp_snippets_service_->snippets()) {
ids.push_back(snippet->id());
@@ -147,6 +149,7 @@ void NTPSnippetsBridge::NTPSnippetsServiceLoaded() {
snippets.push_back(snippet->snippet());
timestamps.push_back(snippet->publish_date().ToJavaTime());
publishers.push_back(snippet->best_source().publisher_name);
+ scores.push_back(snippet->score());
}
JNIEnv* env = base::android::AttachCurrentThread();
@@ -158,7 +161,8 @@ void NTPSnippetsBridge::NTPSnippetsServiceLoaded() {
ToJavaArrayOfStrings(env, thumbnail_urls).obj(),
ToJavaArrayOfStrings(env, snippets).obj(),
ToJavaLongArray(env, timestamps).obj(),
- ToJavaArrayOfStrings(env, publishers).obj());
+ ToJavaArrayOfStrings(env, publishers).obj(),
+ ToJavaFloatArray(env, scores).obj());
}
void NTPSnippetsBridge::NTPSnippetsServiceShutdown() {

Powered by Google App Engine
This is Rietveld 408576698