Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 1996473002: Track age and score of snippets that are clicked (along with position). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: After code review #3 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
index a712773c9dab21a03b3ab8867b9bdc9b55bc193f..eb8dc31ef8bfc8a3e06898940d5fc50af9691aec 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
@@ -111,7 +111,8 @@ public class SnippetsBridge {
@CalledByNative
private void onSnippetsAvailable(String[] ids, String[] titles, String[] urls, String[] ampUrls,
- String[] thumbnailUrls, String[] previewText, long[] timestamps, String[] publishers) {
+ String[] thumbnailUrls, String[] previewText, long[] timestamps, String[] publishers,
+ float[] scores) {
// Don't notify observer if we've already been destroyed.
if (mNativeSnippetsBridge == 0) return;
assert mObserver != null;
@@ -119,7 +120,7 @@ public class SnippetsBridge {
List<SnippetArticle> newSnippets = new ArrayList<>(ids.length);
for (int i = 0; i < ids.length; i++) {
newSnippets.add(new SnippetArticle(ids[i], titles[i], publishers[i], previewText[i],
- urls[i], ampUrls[i], thumbnailUrls[i], timestamps[i], i));
+ urls[i], ampUrls[i], thumbnailUrls[i], timestamps[i], scores[i], i));
}
mObserver.onSnippetsReceived(newSnippets);

Powered by Google App Engine
This is Rietveld 408576698