chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java - Issue 1996473002: Track age and score of snippets that are clicked (along with position).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

Issue 1996473002: Track age and score of snippets that are clicked (along with position). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: After code review #2 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java ('k') | chrome/browser/android/ntp/ntp_snippets_bridge.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

index 327ece2474aff20ca9ed3caf6ac6dd9e89ff31f5..9ec8505bbeb496b39695276cc24a89eb7df415f5 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

@@ -73,7 +73,7 @@ public class NewTabPageAdapterTest {

// The adapter should ignore any new incoming data.

mSnippetsObserver.onSnippetsReceived(Arrays.asList(new SnippetArticle[] {

- new SnippetArticle("foo", "title1", "pub1", "txt1", "foo", "bar", null, 0, 0)}));

+ new SnippetArticle("foo", "title1", "pub1", "txt1", "foo", "bar", null, 0, 0, 0)}));

assertEquals(loadedItems, ntpa.getItemsForTesting());

}

@@ -104,7 +104,7 @@ public class NewTabPageAdapterTest {

// The adapter should ignore any new incoming data.

mSnippetsObserver.onSnippetsReceived(Arrays.asList(new SnippetArticle[] {

- new SnippetArticle("foo", "title1", "pub1", "txt1", "foo", "bar", null, 0, 0)}));

+ new SnippetArticle("foo", "title1", "pub1", "txt1", "foo", "bar", null, 0, 0, 0)}));

assertEquals(loadedItems, ntpa.getItemsForTesting());

}

@@ -134,10 +134,10 @@ public class NewTabPageAdapterTest {

private List<SnippetArticle> createDummySnippets() {

return Arrays.asList(new SnippetArticle[] {

new SnippetArticle("https://site.com/url1", "title1", "pub1", "txt1",

- "https://site.com/url1", "https://amp.site.com/url1", null, 0, 0),

+ "https://site.com/url1", "https://amp.site.com/url1", null, 0, 0, 0),

new SnippetArticle("https://site.com/url2", "title2", "pub2", "txt2",

- "https://site.com/url2", "https://amp.site.com/url1", null, 0, 0),

+ "https://site.com/url2", "https://amp.site.com/url1", null, 0, 0, 0),

new SnippetArticle("https://site.com/url3", "title3", "pub3", "txt3",

- "https://site.com/url3", "https://amp.site.com/url1", null, 0, 0)});

+ "https://site.com/url3", "https://amp.site.com/url1", null, 0, 0, 0)});

}