tools/metrics/histograms/histograms.xml - Issue 1996473002: Track age and score of snippets that are clicked (along with position).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1996473002: Track age and score of snippets that are clicked (along with position). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: After code review #2 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java ('K') | « chrome/browser/android/ntp/ntp_snippets_bridge.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 39895e8d18436b85ee0ae3f753ab1821402d9064..91487b61f328a8041c19443136155decd133b94e 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -33625,6 +33625,26 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="NewTabPage.Snippets.CardClickedAge" units="ms">

+ <owner>jkrcal@chromium.org</owner>

+ <summary>

+ Android: The age of the snippets card on the NTP, that is clicked through to

+ the host website of the content. The age is measured from the moment the

+ content has been published. In each "_x_y" suffix of the

+ histogram, only snippets on positions \gt;=x and \lt;=y are tracked.

+ </summary>

+</histogram>

+<histogram name="NewTabPage.Snippets.CardClickedScore">

Alexei Svitkine (slow) 2016/05/20 14:47:58 Nit: units="score"

jkrcal 2016/05/23 10:01:53 Done.

+ <owner>jkrcal@chromium.org</owner>

+ <summary>

+ Android: The score of the snippets card on the NTP, that is clicked through

+ to the host website of the content. The recorded score is from the moment

+ the snippet was fetched, it could have changed since. In each "_x"

+ suffix of the histogram, only snippets on positions \lt;=x are tracked.

+ </summary>

+</histogram>

<owner>knn@chromium.org</owner>

@@ -94412,6 +94432,15 @@ To add a new entry, add it with any value and run test to compute valid value.

<affected-histogram name="NaCl.Perf.Size.PNaClTranslatedNexe"/>

</histogram_suffixes>

+<histogram_suffixes name="PositionVariants">

+ <suffix name="0_0" label="Only snippets on position 0"/>

+ <suffix name="1_2" label="Only snippets on position 1-2"/>

+ <suffix name="3_4" label="Only snippets on position 3-4"/>

+ <suffix name="5_9" label="Only snippets on position 5-9"/>

+ <affected-histogram name="NewTabPage.Snippets.CardClickedAge"/>

+ <affected-histogram name="NewTabPage.Snippets.CardClickedScore"/>

+</histogram_suffixes>

<histogram_suffixes name="PpapiPluginName">

<suffix name="libwidevinecdmadapter.so"