Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1996463003: Converted Mojo Common Unittests to run as Apptests. (Closed)

Created:
4 years, 7 months ago by Sean Klein
Modified:
4 years, 7 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Converted Mojo Common Unittests to run as Apptests. This removes a dependency from "//mojo/common_common_unittests" to "//mojo/edk/". BUG=None R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/27638ad182fe944f1f5ae9c7a2d3a0c1658e10d2

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Added apptests for data_pipe_utils and message_pump #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -12 lines) Patch
M mojo/BUILD.gn View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M mojo/common/BUILD.gn View 1 2 chunks +6 lines, -5 lines 0 comments Download
M mojo/data_pipe_utils/BUILD.gn View 1 2 3 chunks +5 lines, -1 line 0 comments Download
M mojo/message_pump/BUILD.gn View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M mojo/tools/data/apptests View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M mojo/tools/data/unittests View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sean Klein
4 years, 7 months ago (2016-05-19 22:10:28 UTC) #2
viettrungluu
https://codereview.chromium.org/1996463003/diff/20001/mojo/common/BUILD.gn File mojo/common/BUILD.gn (left): https://codereview.chromium.org/1996463003/diff/20001/mojo/common/BUILD.gn#oldcode46 mojo/common/BUILD.gn:46: "//mojo/data_pipe_utils:tests", This target also contains tests. Arguably it should ...
4 years, 7 months ago (2016-05-19 22:18:49 UTC) #3
Sean Klein
https://codereview.chromium.org/1996463003/diff/20001/mojo/common/BUILD.gn File mojo/common/BUILD.gn (left): https://codereview.chromium.org/1996463003/diff/20001/mojo/common/BUILD.gn#oldcode46 mojo/common/BUILD.gn:46: "//mojo/data_pipe_utils:tests", On 2016/05/19 22:18:49, viettrungluu wrote: > This target ...
4 years, 7 months ago (2016-05-19 22:52:28 UTC) #4
viettrungluu
Awesome, thanks for doing this. LGTM.
4 years, 7 months ago (2016-05-19 22:57:42 UTC) #5
Sean Klein
4 years, 7 months ago (2016-05-19 23:05:50 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
27638ad182fe944f1f5ae9c7a2d3a0c1658e10d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698