Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: content/browser/indexed_db/leveldb/leveldb_transaction.h

Issue 1996443003: Return number of values deleted by IDBObjectStore.delete(range) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes post jsbell dmuprh reviews Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/leveldb/leveldb_transaction.h
diff --git a/content/browser/indexed_db/leveldb/leveldb_transaction.h b/content/browser/indexed_db/leveldb/leveldb_transaction.h
index 988506fac5e6d0f0079651a731d46c32c7da3a35..b14cae15ce3bc0070749addb2225062981bb8c99 100644
--- a/content/browser/indexed_db/leveldb/leveldb_transaction.h
+++ b/content/browser/indexed_db/leveldb/leveldb_transaction.h
@@ -26,7 +26,10 @@ class CONTENT_EXPORT LevelDBTransaction
: public base::RefCounted<LevelDBTransaction> {
public:
void Put(const base::StringPiece& key, std::string* value);
- void Remove(const base::StringPiece& key);
+
+ // Returns true if the record was deleted, and false if it was already
+ // deleted.
jsbell 2016/05/20 19:34:51 already deleted or not present?
palakj1 2016/05/23 17:17:40 Remove returns true if a new delete record is inse
+ bool Remove(const base::StringPiece& key);
virtual leveldb::Status Get(const base::StringPiece& key,
std::string* value,
bool* found);
@@ -129,8 +132,8 @@ class CONTENT_EXPORT LevelDBTransaction
DISALLOW_COPY_AND_ASSIGN(TransactionIterator);
};
-
- void Set(const base::StringPiece& key, std::string* value, bool deleted);
+ // Returns true if the key was originally marked deleted, false otherwise
jsbell 2016/05/20 19:34:51 Nit: period at end of comment.
palakj1 2016/05/23 17:17:40 Done
+ bool Set(const base::StringPiece& key, std::string* value, bool deleted);
void Clear();
void RegisterIterator(TransactionIterator* iterator);
void UnregisterIterator(TransactionIterator* iterator);

Powered by Google App Engine
This is Rietveld 408576698