content/browser/indexed_db/leveldb/leveldb_transaction.h - Issue 1996443003: Return number of values deleted by IDBObjectStore.delete(range)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/leveldb/leveldb_transaction.h

Issue 1996443003: Return number of values deleted by IDBObjectStore.delete(range) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/indexed_db/indexed_db_database.cc ('K') | « content/browser/indexed_db/indexed_db_database.cc ('k') | content/browser/indexed_db/leveldb/leveldb_transaction.cc » ('j') | content/browser/indexed_db/leveldb/leveldb_transaction.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/leveldb/leveldb_transaction.h

diff --git a/content/browser/indexed_db/leveldb/leveldb_transaction.h b/content/browser/indexed_db/leveldb/leveldb_transaction.h

index 988506fac5e6d0f0079651a731d46c32c7da3a35..4075178ed1e23ad6138574b15730b270085e8e1e 100644

--- a/content/browser/indexed_db/leveldb/leveldb_transaction.h

+++ b/content/browser/indexed_db/leveldb/leveldb_transaction.h

@@ -26,7 +26,7 @@ class CONTENT_EXPORT LevelDBTransaction

: public base::RefCounted<LevelDBTransaction> {

public:

void Put(const base::StringPiece& key, std::string* value);

- void Remove(const base::StringPiece& key);

+ bool Remove(const base::StringPiece& key);

dmurph 2016/05/19 01:01:39 Put a comment here: "Returns true if the record w

palakj1 2016/05/19 23:47:52 Done in header file

virtual leveldb::Status Get(const base::StringPiece& key,

std::string* value,

bool* found);

@@ -130,7 +130,6 @@ class CONTENT_EXPORT LevelDBTransaction

DISALLOW_COPY_AND_ASSIGN(TransactionIterator);

};

- void Set(const base::StringPiece& key, std::string* value, bool deleted);

void Clear();

void RegisterIterator(TransactionIterator* iterator);

void UnregisterIterator(TransactionIterator* iterator);