Return number of values deleted by IDBObjectStore.delete(range)

content/browser/indexed_db/indexed_db_backing_store_unittest.cc

Index: content/browser/indexed_db/indexed_db_backing_store_unittest.cc
diff --git a/content/browser/indexed_db/indexed_db_backing_store_unittest.cc b/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
index 7ca56ff5e80438e8690b69f262f88c544435ddb2..113e9307a80d8ea2ef4ad9c5bfdf6fc643440b13 100644
--- a/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
+++ b/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
@@ -459,10 +459,10 @@ TEST_F(IndexedDBBackingStoreTest, PutGetConsistencyWithBlobs) {
     IndexedDBBackingStore::Transaction transaction3(backing_store_.get());
     transaction3.Begin();
     IndexedDBValue result_value;
-    EXPECT_TRUE(backing_store_->DeleteRange(&transaction3,
-                                            1,
-                                            1,
-                                            IndexedDBKeyRange(m_key3)).ok());
+    EXPECT_TRUE(

[dmurph, 2016/05/19 01:01:38]

Do you want to put a check in here somewhere that our deleted count is correct?

[cmumford, 2016/05/19 17:07:15]

+1 dmurph's suggestion - also for the other calls in this file. It's "low
hanging test fruit"

[palakj1, 2016/05/19 23:47:52]

Added.

+        backing_store_
+            ->DeleteRange(&transaction3, 1, 1, IndexedDBKeyRange(m_key3), NULL)
+            .ok());
     scoped_refptr<TestCallback> callback(new TestCallback());
     EXPECT_TRUE(transaction3.CommitPhaseOne(callback).ok());
     task_runner_->RunUntilIdle();
@@ -548,7 +548,8 @@ TEST_F(IndexedDBBackingStoreTest, DeleteRange) {
       transaction2.Begin();
       IndexedDBValue result_value;
       EXPECT_TRUE(
-          backing_store_->DeleteRange(&transaction2, 1, i + 1, ranges[i]).ok());
+          backing_store_->DeleteRange(&transaction2, 1, i + 1, ranges[i], NULL)
+              .ok());
       scoped_refptr<TestCallback> callback(new TestCallback());
       EXPECT_TRUE(transaction2.CommitPhaseOne(callback).ok());
       task_runner_->RunUntilIdle();
@@ -638,7 +639,8 @@ TEST_F(IndexedDBBackingStoreTest, DeleteRangeEmptyRange) {
       transaction2.Begin();
       IndexedDBValue result_value;
       EXPECT_TRUE(
-          backing_store_->DeleteRange(&transaction2, 1, i + 1, ranges[i]).ok());
+          backing_store_->DeleteRange(&transaction2, 1, i + 1, ranges[i], NULL)
+              .ok());
       scoped_refptr<TestCallback> callback(new TestCallback());
       EXPECT_TRUE(transaction2.CommitPhaseOne(callback).ok());
       task_runner_->RunUntilIdle();
@@ -732,10 +734,10 @@ TEST_F(IndexedDBBackingStoreTest, LiveBlobJournal) {
   {
     IndexedDBBackingStore::Transaction transaction3(backing_store_.get());
     transaction3.Begin();
-    EXPECT_TRUE(backing_store_->DeleteRange(&transaction3,
-                                            1,
-                                            1,
-                                            IndexedDBKeyRange(m_key3)).ok());
+    EXPECT_TRUE(
+        backing_store_
+            ->DeleteRange(&transaction3, 1, 1, IndexedDBKeyRange(m_key3), NULL)
+            .ok());
     scoped_refptr<TestCallback> callback(new TestCallback());
     EXPECT_TRUE(transaction3.CommitPhaseOne(callback).ok());
     task_runner_->RunUntilIdle();