Chromium Code Reviews Chromium Code Reviews
Issue 1996443003:
Return number of values deleted by IDBObjectStore.delete(range) (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <!DOCTYPE html> | |
| 2 <title>IndexedDB: UpgradeNeeded Tests</title> | |
| 3 <script src="../../resources/testharness.js"></script> | |
| 4 <script src="../../resources/testharnessreport.js"></script> | |
| 5 <script> | |
| 6 | |
| 7 function delete_count(tests, description) { | |
| 8 async_test(function(t) { | |
| 9 var dbname = location.pathname + ' - ' + description; | |
| 10 var deleteRequest = indexedDB.deleteDatabase(dbname); | |
| 11 deleteRequest.onsuccess = t.step_func(function(){ | |
|
cmumford
2016/05/19 17:07:16
space before {
palakj1
2016/05/19 23:47:52
Done
| |
| 12 var openRequest = indexedDB.open(dbname); | |
| 13 openRequest.onupgradeneeded= t.step_func(function(e) { | |
|
cmumford
2016/05/19 17:07:16
space before =
palakj1
2016/05/19 23:47:53
Done
| |
| 14 var db = e.target.result; | |
| 15 db.createObjectStore('store'); | |
| 16 }); | |
| 17 openRequest.onsuccess = t.step_func(function(e) { | |
| 18 var db = e.target.result; | |
| 19 trans = db.transaction('store', 'readwrite'); | |
|
cmumford
2016/05/19 17:07:16
var before |trans| and |store| and |i| to prevent
palakj1
2016/05/19 23:47:52
Done
| |
| 20 store = trans.objectStore('store'); | |
| 21 for (i = 1; i <= 10; ++i) { | |
| 22 store.put(i,i); | |
| 23 } | |
| 24 var test = tests[0], test1 = tests[1]; | |
|
dmurph
2016/05/19 01:01:39
This is confusing, don't you just want to use the
palakj1
2016/05/19 23:47:53
tests[0] and tests[1] used here might be different
| |
| 25 deleteRequest = store.delete(IDBKeyRange.bound( | |
| 26 test.lower , | |
|
cmumford
2016/05/19 17:07:16
no space before ,
palakj1
2016/05/19 23:47:52
Done
| |
| 27 test.upper , | |
| 28 test.lowerOpen , | |
| 29 test.upperOpen )); | |
| 30 deleteRequestRepeat = store.delete(IDBKeyRange.bound( | |
|
dmurph
2016/05/19 01:01:39
So repeat the same request again, same arguments,
palakj1
2016/05/19 23:47:52
Resolved below
| |
| 31 test1.lower , | |
| 32 test1.upper , | |
| 33 test1.lowerOpen , | |
| 34 test1.upperOpen )); | |
| 35 deleteRequest.onsuccess = t.step_func(function(e) { | |
| 36 var delete_count = e.target.result; | |
| 37 assert_equals(delete_count, test.expected, 'Delete Count'); | |
| 38 }); | |
| 39 deleteRequestRepeat.onsuccess = t.step_func(function(e) { | |
| 40 var delete_count = e.target.result; | |
| 41 assert_equals(delete_count, test1.expected, 'Records already been deleted'); | |
|
dmurph
2016/05/19 01:01:39
This should be 0, correct?
palakj1
2016/05/19 23:47:53
One of my tests have overlapping intervals test =
| |
| 42 t.done(); | |
| 43 }); | |
| 44 }); | |
| 45 openRequest.onerror = t.unreached_func('open failed'); | |
| 46 }); | |
| 47 }, description); | |
| 48 } | |
| 49 | |
| 50 (function(){ | |
| 51 var tests = [ | |
| 52 [{ lower: 3, upper: 4, lowerOpen: false, upperOpen: false, expected: 2}, | |
| 53 { lower: 1, upper: 5, lowerOpen: false, upperOpen: false, expected: 3} | |
| 54 ], | |
| 55 [{ lower: 3, upper: 8, lowerOpen: true, upperOpen: false, expected: 5}, | |
| 56 { lower: 3, upper: 8, lowerOpen: true, upperOpen: false, expected: 0} | |
| 57 ]]; | |
| 58 | |
| 59 delete_count(tests[0], 'Delete Range : Overlapping Intervals'); | |
|
cmumford
2016/05/19 17:07:16
no space before :
| |
| 60 delete_count(tests[1], 'Delete Range: Repeated Intervals'); | |
| 61 }()); | |
| 62 | |
| 63 | |
| 64 | |
| 65 | |
| 66 | |
| 67 </script> | |
| OLD | NEW |
