Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 1996413002: mash: Fix a mash_browser_tests crash on x11. (Closed)

Created:
4 years, 7 months ago by sadrul
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Fix a mash_browser_tests crash on x11. When running as a mus-client, chrome receives from mus, and not from x11. So the X11EventSource instance is not created. BUG=594600 Committed: https://crrev.com/53b25adab2383775bffb34a2c5e266b6375898de Cr-Commit-Position: refs/heads/master@{#395094}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M chrome/browser/chrome_browser_main_extra_parts_x11.cc View 1 chunk +12 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sadrul
4 years, 7 months ago (2016-05-20 15:27:26 UTC) #1
sadrul
4 years, 7 months ago (2016-05-20 15:27:39 UTC) #3
sky
LGTM
4 years, 7 months ago (2016-05-20 16:30:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996413002/1
4 years, 7 months ago (2016-05-20 16:32:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 16:36:35 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 16:38:23 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53b25adab2383775bffb34a2c5e266b6375898de
Cr-Commit-Position: refs/heads/master@{#395094}

Powered by Google App Engine
This is Rietveld 408576698