Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 1996373002: Ship turbofan try-catch, try-finally, attempt N+1. (Closed)

Created:
4 years, 2 months ago by Jarin
Modified:
4 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, mvstanton, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship turbofan try-catch, try-finally, attempt N+1. Committed: https://crrev.com/9aac80f400b174f259a06044e0cf22fe9e2f6af3 Cr-Commit-Position: refs/heads/master@{#36419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ast/ast-numbering.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
4 years, 2 months ago (2016-05-20 14:32:30 UTC) #2
Michael Starzinger
LGTM. As everybody knows, N+1st time's the charm.
4 years, 2 months ago (2016-05-20 14:33:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996373002/1
4 years, 2 months ago (2016-05-20 15:37:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-05-20 15:39:31 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-05-20 15:41:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9aac80f400b174f259a06044e0cf22fe9e2f6af3
Cr-Commit-Position: refs/heads/master@{#36419}

Powered by Google App Engine
This is Rietveld 408576698