Avoid calling updateAllLifecyclePhasesExceptPaint in SVGImage if not needed.

third_party/WebKit/Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 1442 matching lines @@
     }
 
     getHostWindow()->invalidateRect(updateRect);
 }
 
 void FrameView::restoreScrollbar()
 {
     setScrollbarsSuppressed(false);
 }
 
-void FrameView::processUrlFragment(const KURL& url, UrlFragmentBehavior behavior)
+bool FrameView::processUrlFragment(const KURL& url, UrlFragmentBehavior behavior)
 {
+    if (m_currentUrl == url && m_currentUrlFragmentBehavior == behavior)

[fs, 2016/05/23 21:25:56]

Is the general gain great enough to store the url in FrameView, or could we just
store it in SVGImage for now? (Storing the behavior wouldn't be needed because
it's always the same.) Forwarding the return value probably still makes sense.
Another thing to take into account is that if rendering isn't ready on the first
call, the url would still be stored and then the call to processUrlFragment
after rendering is ready would do nothing.

[chrishtr, 2016/05/23 21:29:31]

Indeed. The last point you made is probably a bug in this CL..

+        return false;
+    m_currentUrl = url;
     // If our URL has no ref, then we have no place we need to jump to.
     // OTOH If CSS target was set previously, we want to set it to 0, recalc
     // and possibly paint invalidation because :target pseudo class may have been
     // set (see bug 11321).
     // Similarly for svg, if we had a previous svgView() then we need to reset
     // the initial view if we don't have a fragment.
     if (!url.hasFragmentIdentifier() && !m_frame->document()->cssTarget() && !m_frame->document()->isSVGDocument())
-        return;
-
+        return true;
     String fragmentIdentifier = url.fragmentIdentifier();
     if (processUrlFragmentHelper(fragmentIdentifier, behavior))
-        return;
+        return true;
 
     // Try again after decoding the ref, based on the document's encoding.
     if (m_frame->document()->encoding().isValid())
         processUrlFragmentHelper(decodeURLEscapeSequences(fragmentIdentifier, m_frame->document()->encoding()), behavior);

[fs, 2016/05/23 21:25:56]

if (...)
  return processUrlFragmentHelp...

return false;

?

(Or reverse the if-condition et.c)

-
+    return true;
 }
 
 bool FrameView::processUrlFragmentHelper(const String& name, UrlFragmentBehavior behavior)
 {
     ASSERT(m_frame->document());
 
     if (behavior == UrlFragmentScroll && !m_frame->document()->isRenderingReady()) {
         m_frame->document()->setGotoAnchorNeededAfterStylesheetsLoad(true);
         return false;
     }
@@ skipping 2615 matching lines @@
     return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrottling);
 }
 
 LayoutBox& FrameView::boxForScrollControlPaintInvalidation() const
 {
     ASSERT(layoutView());
     return *layoutView();
 }
 
 } // namespace blink