Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 1996343002: Revert of [Telemetry] Change how trace_data detects if data being added is valid. (Closed)

Created:
4 years, 7 months ago by Sami
Modified:
4 years, 7 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, alexandermont
Base URL:
git@github.com:catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [Telemetry] Change how trace_data detects if data being added is valid. (patchset #2 id:40001 of https://codereview.chromium.org/1998673003/ ) Reason for revert: Reverting to be able to revert another patch which is causing problems on the waterfall: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%283%29/builds/16426/steps/tracing.tracing_with_debug_overhead/logs/stdio Original issue's description: > [Telemetry] Change how trace_data detects if data being added is valid. > > BUG=catapult:#2309 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6dba7972432cb9b6867a25164fab1903d3299036 TBR=charliea@chromium.org,nednguyen@google.com,rnephew@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=catapult:#2309 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/524e30405d39a5f07e10a3e25c4d5ce520afcfef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -30 lines) Patch
M telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent.py View 1 chunk +2 lines, -1 line 0 comments Download
M telemetry/telemetry/timeline/trace_data.py View 2 chunks +6 lines, -9 lines 0 comments Download
M telemetry/telemetry/timeline/trace_data_unittest.py View 1 chunk +10 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Sami
Created Revert of [Telemetry] Change how trace_data detects if data being added is valid.
4 years, 7 months ago (2016-05-20 13:02:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996343002/1
4 years, 7 months ago (2016-05-20 13:02:17 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 13:02:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698