Blink doesnt respect the form.submit() when called on "focus" event for invalid form

Source/core/html/HTMLFormElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 49 matching lines @@
 using namespace HTMLNames;
 
 HTMLFormElement::HTMLFormElement(Document& document)
     : HTMLElement(formTag, document)
     , m_weakPtrFactory(this)
     , m_associatedElementsAreDirty(false)
     , m_imageElementsAreDirty(false)
     , m_hasElementsAssociatedByParser(false)
     , m_didFinishParsingChildren(false)
     , m_wasUserSubmitted(false)
-    , m_isSubmittingOrPreparingForSubmission(false)
+    , m_isSubmitting(false)
     , m_shouldSubmit(false)
     , m_isInResetFunction(false)
     , m_wasDemoted(false)
     , m_requestAutocompleteTimer(this, &HTMLFormElement::requestAutocompleteTimerFired)
 {
     ScriptWrappable::init(this);
 }
 
 PassRefPtr<HTMLFormElement> HTMLFormElement::create(Document& document)
 {
@@ skipping 196 matching lines @@
             document().addConsoleMessage(RenderingMessageSource, ErrorMessageLevel, message);
         }
     }
     return false;
 }
 
 bool HTMLFormElement::prepareForSubmission(Event* event)
 {
     RefPtr<HTMLFormElement> protector(this);
     LocalFrame* frame = document().frame();
-    if (m_isSubmittingOrPreparingForSubmission || !frame)
-        return m_isSubmittingOrPreparingForSubmission;
+    if (m_isSubmitting || !frame)
+        return m_isSubmitting;
 
-    m_isSubmittingOrPreparingForSubmission = true;
     m_shouldSubmit = false;
 
     // Interactive validation must be done before dispatching the submit event.
     if (!validateInteractively(event)) {

[tkent, 2014/03/25 01:56:43]

Any JavaScript code can run in validateInteractively because of invalid and
focus events, and it can call form.submit().  Is it ok?

[harpreet.sk, 2014/03/26 09:16:07]

According to the scenario which you mentioned if form.submit() is called in case
of focus or invalid events it will submit the form which is not the expected
behaviour. So in order to behave correctly i am removing the variable
"m_isSubmitting" completely and introducing a new variable "m_invalidForm" which
will be set to true in case of form being invalidate and it's condition is
checked in submit() api.

[tkent, 2014/03/27 00:35:30]

form.submit() should submit the form even if the form is invalid.
I didn't say form should not be submitted.  I was just afraid any behavior
changes by this CL.

-        m_isSubmittingOrPreparingForSubmission = false;
         return false;
     }
 
     frame->loader().client()->dispatchWillSendSubmitEvent(this);
 
-    // Set flag before submission as dispatchEvent could trigger another event
-    m_isSubmittingOrPreparingForSubmission = false;
-
     if (dispatchEvent(Event::createCancelableBubble(EventTypeNames::submit)))
         m_shouldSubmit = true;
 
     if (m_shouldSubmit)
         submit(event, true, true, NotSubmittedByJavaScript);
 
     return m_shouldSubmit;
 }
 
 void HTMLFormElement::submit()
@@ skipping 16 matching lines @@
     }
 }
 
 void HTMLFormElement::submit(Event* event, bool activateSubmitButton, bool processingUserGesture, FormSubmissionTrigger formSubmissionTrigger)
 {
     FrameView* view = document().view();
     LocalFrame* frame = document().frame();
     if (!view || !frame || !frame->page())
         return;
 
-    if (m_isSubmittingOrPreparingForSubmission) {
+    if (m_isSubmitting) {
         m_shouldSubmit = true;
         return;
     }
 
-    m_isSubmittingOrPreparingForSubmission = true;
+    m_isSubmitting = true;
     m_wasUserSubmitted = processingUserGesture;
 
     RefPtr<HTMLFormControlElement> firstSuccessfulSubmitButton;
     bool needButtonActivation = activateSubmitButton; // do we need to activate a submit button?
 
     const Vector<FormAssociatedElement*>& elements = associatedElements();
     for (unsigned i = 0; i < elements.size(); ++i) {
         FormAssociatedElement* associatedElement = elements[i];
         if (!associatedElement->isFormControlElement())
             continue;
@@ skipping 13 matching lines @@
     EventQueueScope scopeForDialogClose; // Delay dispatching 'close' to dialog until done submitting.
     if (formSubmission->method() == FormSubmission::DialogMethod)
         submitDialog(formSubmission.release());
     else
         scheduleFormSubmission(formSubmission.release());
 
     if (needButtonActivation && firstSuccessfulSubmitButton)
         firstSuccessfulSubmitButton->setActivatedSubmit(false);
 
     m_shouldSubmit = false;
-    m_isSubmittingOrPreparingForSubmission = false;
+    m_isSubmitting = false;
 }
 
 void HTMLFormElement::scheduleFormSubmission(PassRefPtr<FormSubmission> submission)
 {
     ASSERT(submission->method() == FormSubmission::PostMethod || submission->method() == FormSubmission::GetMethod);
     ASSERT(submission->data());
     ASSERT(submission->state());
     if (submission->action().isEmpty())
         return;
     if (document().isSandboxed(SandboxForms)) {
@@ skipping 398 matching lines @@
 }
 
 void HTMLFormElement::setDemoted(bool demoted)
 {
     if (demoted)
         UseCounter::count(document(), UseCounter::DemotedFormElement);
     m_wasDemoted = demoted;
 }
 
 } // namespace