Source/core/html/HTMLFormElement.h - Issue 199633017: Blink doesnt respect the form.submit() when called on "focus" event for invalid form

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/HTMLFormElement.h

Issue 199633017: Blink doesnt respect the form.submit() when called on "focus" event for invalid form (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed unnecessary lines from Layout Test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/forms/submit-onFocus-invalidForm-expected.txt ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2000 Dirk Mueller (mueller@kde.org)	4 * (C) 2000 Dirk Mueller (mueller@kde.org)

5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.	5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 153 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
164 Vector<FormAssociatedElement*> m_associatedElements;	164 Vector<FormAssociatedElement*> m_associatedElements;

165 // Do not access m_imageElements directly. Use imageElements() instead.	165 // Do not access m_imageElements directly. Use imageElements() instead.

166 Vector<HTMLImageElement*> m_imageElements;	166 Vector<HTMLImageElement*> m_imageElements;

167 WeakPtrFactory<HTMLFormElement> m_weakPtrFactory;	167 WeakPtrFactory<HTMLFormElement> m_weakPtrFactory;

168 bool m_associatedElementsAreDirty;	168 bool m_associatedElementsAreDirty;

169 bool m_imageElementsAreDirty;	169 bool m_imageElementsAreDirty;

170 bool m_hasElementsAssociatedByParser;	170 bool m_hasElementsAssociatedByParser;

171 bool m_didFinishParsingChildren;	171 bool m_didFinishParsingChildren;

172	172

173 bool m_wasUserSubmitted;	173 bool m_wasUserSubmitted;

174 bool m_isSubmittingOrPreparingForSubmission;

175 bool m_shouldSubmit;	174 bool m_shouldSubmit;

176	175

177 bool m_isInResetFunction;	176 bool m_isInResetFunction;

178	177

179 bool m_wasDemoted;	178 bool m_wasDemoted;

180	179

181 void requestAutocompleteTimerFired(Timer<HTMLFormElement>*);	180 void requestAutocompleteTimerFired(Timer<HTMLFormElement>*);

182	181

183 Vector<RefPtr<Event> > m_pendingAutocompleteEvents;	182 Vector<RefPtr<Event> > m_pendingAutocompleteEvents;

184 Timer<HTMLFormElement> m_requestAutocompleteTimer;	183 Timer<HTMLFormElement> m_requestAutocompleteTimer;

185 };	184 };

186	185

187 } // namespace WebCore	186 } // namespace WebCore

188	187

189 #endif // HTMLFormElement_h	188 #endif // HTMLFormElement_h

OLD	NEW