Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 199633014: Use wrapper_configuration consistently in bindings (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Use wrapper_configuration consistently in bindings Currently the bindings overuse WrapperConfiguration::Dependent. This changes it to use WrapperConfiguration::Independent unless Dependent is actually needed, by computing it once in the interface context. (Fixes one FIXME and removes some hard-coding.) This is split off as 1/2 bindings-only change from: Implement ImageData constructors. https://codereview.chromium.org/196343032/ BUG=345503 TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169827

Patch Set 1 #

Patch Set 2 : Split off [Constructor] change #

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
Split off first bindings-only change; should be ok, but PTAL.
6 years, 9 months ago (2014-03-24 03:06:39 UTC) #1
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-24 03:06:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/199633014/20001
6 years, 9 months ago (2014-03-24 03:06:48 UTC) #3
haraken
LGTM
6 years, 9 months ago (2014-03-24 03:30:19 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 06:56:27 UTC) #5
Message was sent while issue was closed.
Change committed as 169827

Powered by Google App Engine
This is Rietveld 408576698