Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: chrome/chrome_syzygy.gyp

Issue 199633004: Put the syzygy targets behind a 'syzygy_optimize' flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_syzygy.gyp
diff --git a/chrome/chrome_syzygy.gyp b/chrome/chrome_syzygy.gyp
index c2c81a1588dc211a72a6d858cc9c1aeb173eb360..1850c80226a18eedf21670ef2c8dde7722dc0e6e 100644
--- a/chrome/chrome_syzygy.gyp
+++ b/chrome/chrome_syzygy.gyp
@@ -31,7 +31,7 @@
},
],
}],
- ['OS=="win" and fastbuild==0', {
+ ['OS=="win" and fastbuild==0 and (syzygy_optimize==1 or syzyasan==1)', {
'variables': {
'dll_name': 'chrome',
},
@@ -48,7 +48,8 @@
}],
# Note, not else.
['OS=="win" and fastbuild==0 and chrome_multiple_dll==1 and '
- '(syzyasan!=1 or buildtype!="Official")', {
+ '(syzyasan!=1 or buildtype!="Official") and '
+ '(syzygy_optimize==1 or syzyasan==1)', {
chrisha 2014/03/14 22:01:36 A comment to describe this logic? It's a bit tortu
Sébastien Marchand 2014/03/17 17:41:14 I've refactored this file a little bit.
'variables': {
'dll_name': 'chrome_child',
},

Powered by Google App Engine
This is Rietveld 408576698