chrome/chrome_syzygy.gyp - Issue 199633004: Put the syzygy targets behind a 'syzygy_optimize' flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_syzygy.gyp

Issue 199633004: Put the syzygy targets behind a 'syzygy_optimize' flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_syzygy.gyp

diff --git a/chrome/chrome_syzygy.gyp b/chrome/chrome_syzygy.gyp

index c2c81a1588dc211a72a6d858cc9c1aeb173eb360..1850c80226a18eedf21670ef2c8dde7722dc0e6e 100644

--- a/chrome/chrome_syzygy.gyp

+++ b/chrome/chrome_syzygy.gyp

@@ -31,7 +31,7 @@

}],

- ['OS=="win" and fastbuild==0', {

+ ['OS=="win" and fastbuild==0 and (syzygy_optimize==1 or syzyasan==1)', {

'variables': {

'dll_name': 'chrome',

@@ -48,7 +48,8 @@

}],

# Note, not else.

['OS=="win" and fastbuild==0 and chrome_multiple_dll==1 and '

- '(syzyasan!=1 or buildtype!="Official")', {

+ '(syzyasan!=1 or buildtype!="Official") and '

+ '(syzygy_optimize==1 or syzyasan==1)', {

chrisha 2014/03/14 22:01:36 A comment to describe this logic? It's a bit tortu

Sébastien Marchand 2014/03/17 17:41:14 I've refactored this file a little bit.

'variables': {

'dll_name': 'chrome_child',

« build/common.gypi ('K') | « build/common.gypi ('k') | chrome/chrome_syzygy.gypi » ('j') | chrome/chrome_syzygy.gypi » ('J')