Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1996303003: Fix unreachable code in fwl_comboboximp.cpp (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, brucedawson
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix unreachable code in fwl_comboboximp.cpp Althought this may change behaviour, I'm going to make the assumption that the intent expressed by the current code is what is desired, and that this is simply a case of not being able to count bits properly. BUG=613620, 427616 Committed: https://pdfium.googlesource.com/pdfium/+/24ca59ca1b1475ffdcb9e6202a907627ca24076f

Patch Set 1 #

Patch Set 2 : reorder lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M xfa/fwl/basewidget/ifwl_combobox.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Tom Sepez
Lei, for review. Bruce, FYI.
4 years, 7 months ago (2016-05-20 20:55:38 UTC) #3
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-20 21:00:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996303003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996303003/20001
4 years, 7 months ago (2016-05-20 21:01:53 UTC) #7
brucedawson
lgtm - I added bug 427616 'cause I like to track fixes due to /analyze.
4 years, 7 months ago (2016-05-20 21:02:18 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 21:25:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/24ca59ca1b1475ffdcb9e6202a907627ca24...

Powered by Google App Engine
This is Rietveld 408576698