[Tracing] Introduce Frame Data Side Panel

tracing/tracing/model/model.html

Index: tracing/tracing/model/model.html
diff --git a/tracing/tracing/model/model.html b/tracing/tracing/model/model.html
index 35c75ea190a2fa95aa5c96d139dadcf7c7fe3d99..3d747a9a0bdf02beb73a92ac195f7903ecc9a9d4 100644
--- a/tracing/tracing/model/model.html
+++ b/tracing/tracing/model/model.html
@@ -558,6 +558,11 @@ tr.exportTo('tr', function() {
               patchup.scopedId, patchup.ts);
           if (snapshot) {
             patchup.object[patchup.field] = snapshot;
+            // TODO(xiaochengh): Find a saner approach.
+            if (snapshot instanceof tr.e.chrome.BlameContextSnapshot) {

[petrcermak, 2016/05/24 10:54:10]

Maybe you could use `snapshot.eventSet !== undefined`? I would really like to
avoid accessing extras from the model.

[Xiaocheng, 2016/05/25 10:17:47]

This part is rewritten by adding a callback
|ObjectSnapshot.appliedObjectRefPatchup| and overriding it in BlameContext.

+              if (patchup.item.duration)

[petrcermak, 2016/05/24 10:54:10]

Just checking: Is it intended that this is false even if the duration is defined
but zero?

[Xiaocheng, 2016/05/25 10:17:47]

Good catch. The intention is to add only slices, so it should be |patchup.item
instanceof tr.model.Slice|.

+                snapshot.eventSet.push(patchup.item);
+            }
             return;
           }
         }
@@ -655,6 +660,7 @@ tr.exportTo('tr', function() {
         // refs have been located. Otherwise, we could end up recursing in
         // ways we definitely didn't intend.
         patchupsToApply.push({
+          item: item,
           object: object,
           field: fieldName,
           pidRef: pidRef,