Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1996283002: Animation: Declare explicit specialization of VectorTraits before use (Closed)

Created:
4 years, 7 months ago by Eric Willigers
Modified:
4 years, 7 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Animation: Declare explicit specialization of VectorTraits before use The specialization of VectorTraits for NewAnimation and UpdatedAnimation is now defined before VectorTraits is used, for example in CSSAnimationUpdate::startAnimation which appends to a HeapVector. BUG=613472 R=alancutter Committed: https://crrev.com/5b9c6d09be1e69c2fd97bdcc0ca4c07a1d6d7528 Cr-Commit-Position: refs/heads/master@{#395293}

Patch Set 1 #

Patch Set 2 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -65 lines) Patch
M third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h View 1 6 chunks +67 lines, -63 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.h View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Eric Willigers
4 years, 7 months ago (2016-05-20 06:53:48 UTC) #1
alancutter (OOO until 2018)
lgtm with nit.
4 years, 7 months ago (2016-05-23 00:40:04 UTC) #2
alancutter (OOO until 2018)
On 2016/05/23 at 00:40:04, alancutter wrote: > lgtm with nit. I would rename these as ...
4 years, 7 months ago (2016-05-23 00:40:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996283002/20001
4 years, 7 months ago (2016-05-23 02:50:30 UTC) #6
Eric Willigers
> I would rename these as NewCSSAnimation and UpdatedCSSAnimation. Done
4 years, 7 months ago (2016-05-23 02:53:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233558)
4 years, 7 months ago (2016-05-23 05:20:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996283002/20001
4 years, 7 months ago (2016-05-23 05:47:18 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-23 08:28:13 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 08:29:12 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5b9c6d09be1e69c2fd97bdcc0ca4c07a1d6d7528
Cr-Commit-Position: refs/heads/master@{#395293}

Powered by Google App Engine
This is Rietveld 408576698