Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1996273002: Fix arm64 linux compilation errors. (Closed)

Created:
4 years, 7 months ago by apatole
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix arm64 linux compilation errors. Fixes 'undeclared identifier __NR_access/__NR_open' compile errors. __NR_access and __NR_open don't exist on ARM64. So, like the earlier code in same file, added __NR_access and __NR_open case under !defined(__aarch64__) check. BUG=613452 Committed: https://crrev.com/bf7b161de8c47f70b70eb4bd5b28224c1a16ed53 Cr-Commit-Position: refs/heads/master@{#397767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M services/shell/runner/host/linux_sandbox.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
apatole
On 2016/05/24 06:32:15, apatole wrote: > mailto:apatole@nvidia.com changed reviewers: > + mailto:rickyz@chromium.org @rickyz, Let, me ...
4 years, 6 months ago (2016-05-30 06:47:22 UTC) #3
apatole
ptal.
4 years, 6 months ago (2016-06-03 12:31:49 UTC) #5
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-06-03 17:19:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996273002/1
4 years, 6 months ago (2016-06-03 18:07:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 18:58:22 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 19:00:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf7b161de8c47f70b70eb4bd5b28224c1a16ed53
Cr-Commit-Position: refs/heads/master@{#397767}

Powered by Google App Engine
This is Rietveld 408576698