Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 1996233002: [Media Router WebUI] Update element positioning after delayed imports. (Closed)

Created:
4 years, 7 months ago by btolsch
Modified:
4 years, 7 months ago
Reviewers:
apacible
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Update element positioning after delayed imports. This change adds a call to update the positioning of dialog elements after the delayed html imports have finished. Delaying the imports seems to cause the first run flow element (which is conditionally templated) to have an offsetHeight of 0 after it is stamped but before the imports complete. Adding another update call lets the update correctly see this element's offsetHeight when it is supposed to be visible. R=apacible@chromium.org BUG=612726 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2786224a2dd9f8b5d785b589be26500900d9e5b0 Cr-Commit-Position: refs/heads/master@{#395116}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 1 chunk +16 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
btolsch
I'm not sure why the loads are causing this problem but I will investigate it. ...
4 years, 7 months ago (2016-05-20 01:46:17 UTC) #2
apacible
Very similar to what I have locally (but haven't sent out)! :) Please update the ...
4 years, 7 months ago (2016-05-20 05:22:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996233002/1
4 years, 7 months ago (2016-05-20 17:25:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 18:09:29 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 18:11:32 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2786224a2dd9f8b5d785b589be26500900d9e5b0
Cr-Commit-Position: refs/heads/master@{#395116}

Powered by Google App Engine
This is Rietveld 408576698