Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1996083002: Adding missing wgl_api_unittest.cc to Windows gn build (Closed)

Created:
4 years, 7 months ago by brucedawson
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding missing wgl_api_unittest.cc to Windows gn build BUG=604060 Committed: https://crrev.com/a456f5bda5a89dbe92a59b96a43c3e8dbf59a77d Cr-Commit-Position: refs/heads/master@{#394818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/gl/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
brucedawson
Just adding the last few unit tests that are missing from the Windows gn build. ...
4 years, 7 months ago (2016-05-19 17:31:18 UTC) #2
Ken Russell (switch to Gerrit)
lgtm How'd you find the missing file?
4 years, 7 months ago (2016-05-19 17:45:47 UTC) #3
brucedawson
On 2016/05/19 17:45:47, Ken Russell wrote: > lgtm > > How'd you find the missing ...
4 years, 7 months ago (2016-05-19 17:52:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996083002/1
4 years, 7 months ago (2016-05-19 17:53:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 18:33:07 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 18:34:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a456f5bda5a89dbe92a59b96a43c3e8dbf59a77d
Cr-Commit-Position: refs/heads/master@{#394818}

Powered by Google App Engine
This is Rietveld 408576698