Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1996053002: [Android] Turn down gn-specific Android bots. (Closed)

Created:
4 years, 7 months ago by jbudorick
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[Android] Turn down gn-specific Android bots. All Android bots are now on GN, so there's no longer a reason for these to exist. BUG=610839 Committed: https://chromium.googlesource.com/chromium/tools/build/+/9787bd7b6efc5931d240a979ff3b1250da038070

Patch Set 1 #

Total comments: 3

Patch Set 2 : expectation changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2032 lines) Patch
M masters/master.chromium.android/builders.pyl View 3 chunks +2 lines, -18 lines 0 comments Download
M masters/master.chromium.linux/master_android_cfg.py View 1 chunk +0 lines, -2 lines 0 comments Download
M masters/master.chromium.linux/slaves.cfg View 1 chunk +0 lines, -16 lines 0 comments Download
M masters/master.tryserver.chromium.android/builders.pyl View 2 chunks +0 lines, -20 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_android.py View 1 chunk +0 lines, -24 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_linux.py View 2 chunks +0 lines, -43 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_recipe.md View 1 chunk +4 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/trybots.py View 1 chunk +0 lines, -12 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_android_Android_GN_Builder__dbg_.json View 1 1 chunk +0 lines, -351 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_GN.json View 1 1 chunk +0 lines, -330 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_GN__dbg_.json View 1 1 chunk +0 lines, -330 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_chromium_gn_compile_dbg.json View 1 1 chunk +0 lines, -294 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_chromium_gn_compile_rel.json View 1 1 chunk +0 lines, -294 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_chromium_gn_rel.json View 1 1 chunk +0 lines, -294 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jbudorick
4 years, 7 months ago (2016-05-19 16:09:39 UTC) #2
Dirk Pranke
lgtm. Don't forget to take them out of the chromium CQ first, though (//infra/config/cq.cfg).
4 years, 7 months ago (2016-05-19 18:33:40 UTC) #3
jbudorick
On 2016/05/19 18:33:40, Dirk Pranke wrote: > lgtm. > > Don't forget to take them ...
4 years, 7 months ago (2016-05-19 18:34:19 UTC) #4
ghost stip (do not use)
lgtm https://chromiumcodereview.appspot.com/1996053002/diff/1/masters/master.chromium.android/builders.pyl File masters/master.chromium.android/builders.pyl (right): https://chromiumcodereview.appspot.com/1996053002/diff/1/masters/master.chromium.android/builders.pyl#newcode216 masters/master.chromium.android/builders.pyl:216: "slave41-c1", oh nice https://chromiumcodereview.appspot.com/1996053002/diff/1/masters/master.chromium.linux/slaves.cfg File masters/master.chromium.linux/slaves.cfg (left): https://chromiumcodereview.appspot.com/1996053002/diff/1/masters/master.chromium.linux/slaves.cfg#oldcode125 ...
4 years, 7 months ago (2016-05-19 19:09:42 UTC) #5
jbudorick
https://codereview.chromium.org/1996053002/diff/1/masters/master.chromium.linux/slaves.cfg File masters/master.chromium.linux/slaves.cfg (left): https://codereview.chromium.org/1996053002/diff/1/masters/master.chromium.linux/slaves.cfg#oldcode125 masters/master.chromium.linux/slaves.cfg:125: 'hostname': 'build36-b1', On 2016/05/19 19:09:41, stip wrote: > can ...
4 years, 7 months ago (2016-05-19 19:12:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996053002/20001
4 years, 7 months ago (2016-05-23 14:06:35 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 14:10:14 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/9787bd7b6efc5931d240...

Powered by Google App Engine
This is Rietveld 408576698