Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: content/browser/media/session/media_session.h

Issue 1996043002: Split MediaContentType and AudioFocusType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Mounir's comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/session/media_session.h
diff --git a/content/browser/media/session/media_session.h b/content/browser/media/session/media_session.h
index 044a2676600f4dc619a134b4da19501692f96d41..1dac4451f4f57540687d03cd971ef2e367f5acb0 100644
--- a/content/browser/media/session/media_session.h
+++ b/content/browser/media/session/media_session.h
@@ -10,6 +10,7 @@
#include "base/callback_list.h"
#include "base/id_map.h"
#include "base/macros.h"
+#include "content/browser/media/session/audio_focus_manager.h"
#include "content/browser/media/session/media_session_uma_helper.h"
#include "content/common/content_export.h"
#include "content/public/browser/web_contents_observer.h"
@@ -18,6 +19,11 @@
class MediaSessionBrowserTest;
+namespace media {
+
whywhat 2016/08/18 20:33:42 nit: remove the blank line
Zhiqiang Zhang (Slow) 2016/08/19 15:05:55 Done.
+enum class MediaContentType;
+}
whywhat 2016/08/18 20:33:42 nit: add the // namespace comment
Zhiqiang Zhang (Slow) 2016/08/19 15:05:55 Done.
+
namespace content {
class AudioFocusManagerTest;
@@ -43,11 +49,6 @@ class MediaSessionVisibilityBrowserTest;
class MediaSession : public WebContentsObserver,
protected WebContentsUserData<MediaSession> {
public:
- enum class Type {
- Content,
- Transient
- };
-
enum class SuspendType {
// Suspended by the system because a transient sound needs to be played.
SYSTEM,
@@ -70,7 +71,8 @@ class MediaSession : public WebContentsObserver,
// player was successfully added. If it returns false, AddPlayer() should be
// called again later.
CONTENT_EXPORT bool AddPlayer(MediaSessionObserver* observer,
- int player_id, Type type);
+ int player_id,
+ media::MediaContentType type);
// Removes the given player from the current media session. Abandons audio
// focus if that was the last player in the session.
@@ -132,7 +134,8 @@ class MediaSession : public WebContentsObserver,
CONTENT_EXPORT void SetDelegateForTests(
std::unique_ptr<MediaSessionDelegate> delegate);
CONTENT_EXPORT bool IsActiveForTest() const;
- CONTENT_EXPORT Type audio_focus_type_for_test() const;
+ CONTENT_EXPORT AudioFocusManager::AudioFocusType audio_focus_type_for_test()
+ const;
CONTENT_EXPORT void RemoveAllPlayersForTest();
CONTENT_EXPORT MediaSessionUmaHelper* uma_helper_for_test();
@@ -170,7 +173,7 @@ class MediaSession : public WebContentsObserver,
// Requests audio focus to the MediaSessionDelegate.
// Returns whether the request was granted.
- bool RequestSystemAudioFocus(Type type);
+ bool RequestSystemAudioFocus(AudioFocusManager::AudioFocusType type);
// To be called after a call to AbandonAudioFocus() in order request the
// delegate to abandon the audio focus.
@@ -193,7 +196,7 @@ class MediaSession : public WebContentsObserver,
State audio_focus_state_;
SuspendType suspend_type_;
- Type audio_focus_type_;
+ AudioFocusManager::AudioFocusType audio_focus_type_;
MediaSessionUmaHelper uma_helper_;

Powered by Google App Engine
This is Rietveld 408576698