DEPS - Issue 1996033002: Do not define use_icu_data_file_flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: DEPS

Issue 1996033002: Do not define use_icu_data_file_flag. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: DEPS

diff --git a/DEPS b/DEPS

index fb11765a7441302b2e88a9e940b9e95495f83227..4faa3f087f8e6e8bee199b36eb911cb62dee093b 100644

--- a/DEPS

+++ b/DEPS

@@ -12,7 +12,7 @@ deps = {

"v8/tools/gyp":

Var("git_url") + "/external/gyp.git" + "@" + "bce1c7793010574d88d7915e2d55395213ac63d1",

"v8/third_party/icu":

- Var("git_url") + "/chromium/deps/icu.git" + "@" + "c291cde264469b20ca969ce8832088acb21e0c48",

+ Var("git_url") + "/chromium/deps/icu.git" + "@" + "d9f48be67ba790adbc59d3ab195b2d8278c9d73b",

Michael Achenbach 2016/05/19 14:56:25 This should point to what chromium points to. Othe

altimin 2016/05/19 15:03:46 Yes, I've updated chromium's DEPS to this revision

"v8/buildtools":

Var("git_url") + "/chromium/buildtools.git" + "@" + "06e80a0e17319868d4a9b13f9bb6a248dc8d8b20",

"v8/base/trace_event/common":

« BUILD.gn ('K') | « BUILD.gn ('k') | build_overrides/v8.gni » ('j') | no next file with comments »