Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: BUILD.gn

Issue 1996033002: Do not define use_icu_data_file_flag. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | DEPS » ('j') | DEPS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index b55e5639a0e542d22143be85bde8096d1408c6e3..b08fbb8efa0a22c805283e4240d2742fbd6cabe8 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -18,10 +18,6 @@ import("//build_overrides/v8.gni")
import("snapshot_toolchain.gni")
declare_args() {
- # Use ICU data file (icudtl.dat) if true or library (shared on windows,
- # static otherwise).
- icu_use_data_file_flag = true
-
# Enable the snapshot feature, for fast context creation.
# http://v8project.blogspot.com/2015/09/custom-startup-snapshots.html
v8_use_snapshot = true
@@ -1839,14 +1835,6 @@ v8_source_set("v8_base") {
if (is_win) {
deps += [ "//third_party/icu:icudata" ]
}
-
Michael Achenbach 2016/05/19 14:56:25 Is ICU exporting this as a public config now? E.g.
altimin 2016/05/19 15:03:45 Yes: https://code.google.com/p/chromium/codesearch
- if (icu_use_data_file_flag) {
- defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE" ]
- } else if (is_win) {
- defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_SHARED" ]
- } else {
- defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC" ]
- }
} else {
sources -= [
"src/i18n.cc",
« no previous file with comments | « no previous file | DEPS » ('j') | DEPS » ('J')

Powered by Google App Engine
This is Rietveld 408576698