Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Side by Side Diff: BUILD.gn

Issue 1996033002: Do not define use_icu_data_file_flag. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | DEPS » ('j') | DEPS » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/arm.gni") 6 import("//build/config/arm.gni")
7 import("//build/config/mips.gni") 7 import("//build/config/mips.gni")
8 import("//build/config/sanitizers/sanitizers.gni") 8 import("//build/config/sanitizers/sanitizers.gni")
9 9
10 if (is_android) { 10 if (is_android) {
11 import("//build/config/android/rules.gni") 11 import("//build/config/android/rules.gni")
12 } 12 }
13 13
14 # Because standalone V8 builds are not supported, assume this is part of a 14 # Because standalone V8 builds are not supported, assume this is part of a
15 # Chromium build. 15 # Chromium build.
16 import("//build_overrides/v8.gni") 16 import("//build_overrides/v8.gni")
17 17
18 import("snapshot_toolchain.gni") 18 import("snapshot_toolchain.gni")
19 19
20 declare_args() { 20 declare_args() {
21 # Use ICU data file (icudtl.dat) if true or library (shared on windows,
22 # static otherwise).
23 icu_use_data_file_flag = true
24
25 # Enable the snapshot feature, for fast context creation. 21 # Enable the snapshot feature, for fast context creation.
26 # http://v8project.blogspot.com/2015/09/custom-startup-snapshots.html 22 # http://v8project.blogspot.com/2015/09/custom-startup-snapshots.html
27 v8_use_snapshot = true 23 v8_use_snapshot = true
28 24
29 # Use external files for startup data blobs: 25 # Use external files for startup data blobs:
30 # the JS builtins sources and the start snapshot. 26 # the JS builtins sources and the start snapshot.
31 v8_use_external_startup_data = true 27 v8_use_external_startup_data = true
32 28
33 # Sets -DVERIFY_HEAP. 29 # Sets -DVERIFY_HEAP.
34 v8_enable_verify_heap = false 30 v8_enable_verify_heap = false
(...skipping 1797 matching lines...) Expand 10 before | Expand all | Expand 10 after
1832 if (is_win) { 1828 if (is_win) {
1833 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 1829 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
1834 cflags = [ "/wd4267" ] 1830 cflags = [ "/wd4267" ]
1835 } 1831 }
1836 1832
1837 if (v8_enable_i18n_support) { 1833 if (v8_enable_i18n_support) {
1838 deps += [ "//third_party/icu" ] 1834 deps += [ "//third_party/icu" ]
1839 if (is_win) { 1835 if (is_win) {
1840 deps += [ "//third_party/icu:icudata" ] 1836 deps += [ "//third_party/icu:icudata" ]
1841 } 1837 }
1842
Michael Achenbach 2016/05/19 14:56:25 Is ICU exporting this as a public config now? E.g.
altimin 2016/05/19 15:03:45 Yes: https://code.google.com/p/chromium/codesearch
1843 if (icu_use_data_file_flag) {
1844 defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE" ]
1845 } else if (is_win) {
1846 defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_SHARED" ]
1847 } else {
1848 defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC" ]
1849 }
1850 } else { 1838 } else {
1851 sources -= [ 1839 sources -= [
1852 "src/i18n.cc", 1840 "src/i18n.cc",
1853 "src/i18n.h", 1841 "src/i18n.h",
1854 ] 1842 ]
1855 } 1843 }
1856 1844
1857 if (v8_postmortem_support) { 1845 if (v8_postmortem_support) {
1858 sources += [ "$target_gen_dir/debug-support.cc" ] 1846 sources += [ "$target_gen_dir/debug-support.cc" ]
1859 deps += [ ":postmortem-metadata" ] 1847 deps += [ ":postmortem-metadata" ]
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
2196 sources = [ 2184 sources = [
2197 "test/fuzzer/wasm-asmjs.cc", 2185 "test/fuzzer/wasm-asmjs.cc",
2198 ] 2186 ]
2199 2187
2200 deps = [ 2188 deps = [
2201 ":fuzzer_support", 2189 ":fuzzer_support",
2202 ] 2190 ]
2203 2191
2204 configs = [ ":internal_config" ] 2192 configs = [ ":internal_config" ]
2205 } 2193 }
OLDNEW
« no previous file with comments | « no previous file | DEPS » ('j') | DEPS » ('J')

Powered by Google App Engine
This is Rietveld 408576698