Do not define use_icu_data_file_flag.

Do not define use_icu_data_file_flag.

use_icu_data_file from //third_party/icu should be used.
//third_party/icu also defines ICU_UTIL_DATA_IMPL.

BUG=chromium:610673, chromium:474921
Committed: https://crrev.com/a2956f4243f6336ad772372d97cc497d6177d2a7
Cr-Commit-Position: refs/heads/master@{#36371}

[altimin, 2016-05-19 14:16:33]

Description was changed from

==========
Do not define use_icu_data_file_flag.

use_icu_data_file from //third_party/icu should be used.
Also //third_party/icu defines ICU_UTIL_DATA_IMPL.

BUG=
==========

to

==========
Do not define use_icu_data_file_flag.

use_icu_data_file from //third_party/icu should be used.
Also //third_party/icu defines ICU_UTIL_DATA_IMPL.

BUG=chromium:610673
R=machenbach@chromium.org,vogelheim@chromium.org
CC=alexclarke@chromium.org,skyostil@chromium.org
==========

[altimin, 2016-05-19 14:17:05]

Description was changed from

==========
Do not define use_icu_data_file_flag.

use_icu_data_file from //third_party/icu should be used.
Also //third_party/icu defines ICU_UTIL_DATA_IMPL.

BUG=chromium:610673
R=machenbach@chromium.org,vogelheim@chromium.org
CC=alexclarke@chromium.org,skyostil@chromium.org
==========

to

==========
Do not define use_icu_data_file_flag.

use_icu_data_file from //third_party/icu should be used.
Also //third_party/icu defines ICU_UTIL_DATA_IMPL.

BUG=chromium:610673
==========

[altimin, 2016-05-19 14:17:05]

altimin@chromium.org changed reviewers:
+ machenbach@chromium.org, vogelheim@chromium.org

[altimin, 2016-05-19 14:17:17]

Description was changed from

==========
Do not define use_icu_data_file_flag.

use_icu_data_file from //third_party/icu should be used.
Also //third_party/icu defines ICU_UTIL_DATA_IMPL.

BUG=chromium:610673
==========

to

==========
Do not define use_icu_data_file_flag.

use_icu_data_file from //third_party/icu should be used.
//third_party/icu also defines ICU_UTIL_DATA_IMPL.

BUG=chromium:610673
==========

[Sami, 2016-05-19 14:26:05]

skyostil@chromium.org changed reviewers:
+ skyostil@chromium.org

[Sami, 2016-05-19 14:26:05]

Non-owner lgtm.

[Michael Achenbach, 2016-05-19 14:54:29]

Description was changed from

==========
Do not define use_icu_data_file_flag.

use_icu_data_file from //third_party/icu should be used.
//third_party/icu also defines ICU_UTIL_DATA_IMPL.

BUG=chromium:610673
==========

to

==========
Do not define use_icu_data_file_flag.

use_icu_data_file from //third_party/icu should be used.
//third_party/icu also defines ICU_UTIL_DATA_IMPL.

BUG=chromium:610673,chromium:474921
NOTRY=true
==========

[Michael Achenbach, 2016-05-19 14:56:25]

https://codereview.chromium.org/1996033002/diff/1/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/1996033002/diff/1/BUILD.gn#oldcode1842
BUILD.gn:1842: 
Is ICU exporting this as a public config now? E.g. will the defines be set for
the v8 targets as well?

https://codereview.chromium.org/1996033002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/1996033002/diff/1/DEPS#newcode15
DEPS:15: Var("git_url") + "/chromium/deps/icu.git" + "@" +
"d9f48be67ba790adbc59d3ab195b2d8278c9d73b",
This should point to what chromium points to. Otherwise our auto-roller will
overwrite it.

[Michael Achenbach, 2016-05-19 14:56:32]

Description was changed from

==========
Do not define use_icu_data_file_flag.

use_icu_data_file from //third_party/icu should be used.
//third_party/icu also defines ICU_UTIL_DATA_IMPL.

BUG=chromium:610673,chromium:474921
NOTRY=true
==========

to

==========
Do not define use_icu_data_file_flag.

use_icu_data_file from //third_party/icu should be used.
//third_party/icu also defines ICU_UTIL_DATA_IMPL.

BUG=chromium:610673,chromium:474921
==========

[altimin, 2016-05-19 15:03:46]

PTAL.

https://codereview.chromium.org/1996033002/diff/1/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/1996033002/diff/1/BUILD.gn#oldcode1842
BUILD.gn:1842: 
On 2016/05/19 14:56:25, Michael Achenbach (slow) wrote:
> Is ICU exporting this as a public config now? E.g. will the defines be set
for
> the v8 targets as well?

Yes:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/icu/BU...

https://codereview.chromium.org/1996033002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/1996033002/diff/1/DEPS#newcode15
DEPS:15: Var("git_url") + "/chromium/deps/icu.git" + "@" +
"d9f48be67ba790adbc59d3ab195b2d8278c9d73b",
On 2016/05/19 14:56:25, Michael Achenbach (slow) wrote:
> This should point to what chromium points to. Otherwise our auto-roller will
> overwrite it.

Yes, I've updated chromium's DEPS to this revision yesterday.

[Michael Achenbach, 2016-05-19 15:13:28]

lgtm, thanks!

[Michael Achenbach, 2016-05-19 15:15:01]

Note that v8 might not roll for two days now due to branching. Is this needed
for M52?

[altimin, 2016-05-19 15:21:46]

On 2016/05/19 15:15:01, Michael Achenbach (slow) wrote:
> Note that v8 might not roll for two days now due to branching. Is this needed
> for M52?

Thanks for letting me know. But it's not needed for M52.

[altimin, 2016-05-19 15:21:53]

The CQ bit was checked by altimin@chromium.org

[commit-bot: I haz the power, 2016-05-19 15:22:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1996033002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1996033002/1

[commit-bot: I haz the power, 2016-05-19 15:50:20]

Description was changed from

==========
Do not define use_icu_data_file_flag.

use_icu_data_file from //third_party/icu should be used.
//third_party/icu also defines ICU_UTIL_DATA_IMPL.

BUG=chromium:610673,chromium:474921
==========

to

==========
Do not define use_icu_data_file_flag.

use_icu_data_file from //third_party/icu should be used.
//third_party/icu also defines ICU_UTIL_DATA_IMPL.

BUG=chromium:610673,chromium:474921
==========

[commit-bot: I haz the power, 2016-05-19 15:50:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-19 15:50:45]

Description was changed from

==========
Do not define use_icu_data_file_flag.

use_icu_data_file from //third_party/icu should be used.
//third_party/icu also defines ICU_UTIL_DATA_IMPL.

BUG=chromium:610673,chromium:474921
==========

to

==========
Do not define use_icu_data_file_flag.

use_icu_data_file from //third_party/icu should be used.
//third_party/icu also defines ICU_UTIL_DATA_IMPL.

BUG=chromium:610673,chromium:474921

Committed: https://crrev.com/a2956f4243f6336ad772372d97cc497d6177d2a7
Cr-Commit-Position: refs/heads/master@{#36371}
==========

[commit-bot: I haz the power, 2016-05-19 15:50:46]

Patchset 1 (id:??) landed as
https://crrev.com/a2956f4243f6336ad772372d97cc497d6177d2a7
Cr-Commit-Position: refs/heads/master@{#36371}