Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: chrome/browser/ui/webui/options/settings_format_browsertest.js

Issue 1996013005: Disable flaky test SettingsFormatWebUITest.CheckboxIdOrPrefCheck (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 GEN_INCLUDE(['options_browsertest_base.js']); 5 GEN_INCLUDE(['options_browsertest_base.js']);
6 6
7 /** 7 /**
8 * TestFixture for testing the formatting of settings pages. 8 * TestFixture for testing the formatting of settings pages.
9 * @extends {testing.Test} 9 * @extends {testing.Test}
10 * @constructor 10 * @constructor
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 for (var i = 0; i < elements.length; i++) { 141 for (var i = 0; i < elements.length; i++) {
142 var element = elements[i]; 142 var element = elements[i];
143 if (!findAncestorByClass(element, element.type)) 143 if (!findAncestorByClass(element, element.type))
144 this.fail('MISSING_CHECK_WRAPPER', element, element.type); 144 this.fail('MISSING_CHECK_WRAPPER', element, element.type);
145 } 145 }
146 }); 146 });
147 147
148 /** 148 /**
149 * Each checkbox requires an id or pref property. 149 * Each checkbox requires an id or pref property.
150 */ 150 */
151 TEST_F('SettingsFormatWebUITest', 'CheckboxIdOrPrefCheck', function() { 151 // Flaky crashes on all platforms; http://crbug.com/613034.
152 TEST_F('SettingsFormatWebUITest', 'DISABLED_CheckboxIdOrPrefCheck', function() {
152 var query = 153 var query =
153 'input[type=checkbox]:not([pref]):not([id]):not(.spacer-checkbox)'; 154 'input[type=checkbox]:not([pref]):not([id]):not(.spacer-checkbox)';
154 var elements = document.querySelectorAll(query); 155 var elements = document.querySelectorAll(query);
155 for (var i = 0; i < elements.length; i++) { 156 for (var i = 0; i < elements.length; i++) {
156 var element = elements[i]; 157 var element = elements[i];
157 if (!this.isExempt(element, SettingsFormatWebUITest.Filters['pref'])) 158 if (!this.isExempt(element, SettingsFormatWebUITest.Filters['pref']))
158 this.fail('MISSING_ID_OR_PREF', element); 159 this.fail('MISSING_ID_OR_PREF', element);
159 } 160 }
160 }); 161 });
161 162
162 /** 163 /**
163 * Each radio button requires name and value properties. 164 * Each radio button requires name and value properties.
164 */ 165 */
165 TEST_F('SettingsFormatWebUITest', 'RadioButtonNameValueCheck', function() { 166 TEST_F('SettingsFormatWebUITest', 'RadioButtonNameValueCheck', function() {
166 var elements = document.querySelectorAll('input[type=radio]'); 167 var elements = document.querySelectorAll('input[type=radio]');
167 for (var i = 0; i < elements.length; i++) { 168 for (var i = 0; i < elements.length; i++) {
168 var element = elements[i]; 169 var element = elements[i];
169 if (!element.name) 170 if (!element.name)
170 this.fail('MISSING_RADIO_BUTTON_NAME', element); 171 this.fail('MISSING_RADIO_BUTTON_NAME', element);
171 172
172 if (!element.getAttribute('value')) 173 if (!element.getAttribute('value'))
173 this.fail('MISSING_RADIO_BUTTON_VALUE', element); 174 this.fail('MISSING_RADIO_BUTTON_VALUE', element);
174 } 175 }
175 }); 176 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698