Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1995933003: MD User Manager: Hover and Focus states for the custodian accounts dropdown (Closed)

Created:
4 years, 7 months ago by Moe
Modified:
4 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD User Manager: Hover and Focus states for the custodian accounts dropdown BUG=563722, 612766 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3f03e9c251f1751a1298830fc1187c8d816055f7 Cr-Commit-Position: refs/heads/master@{#395063}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/resources/md_user_manager/create_profile.html View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Moe
Hi Michael, Please review this CL.
4 years, 7 months ago (2016-05-19 13:38:15 UTC) #3
michaelpg
https://codereview.chromium.org/1995933003/diff/1/chrome/browser/resources/md_user_manager/create_profile.html File chrome/browser/resources/md_user_manager/create_profile.html (right): https://codereview.chromium.org/1995933003/diff/1/chrome/browser/resources/md_user_manager/create_profile.html#newcode131 chrome/browser/resources/md_user_manager/create_profile.html:131: } ;
4 years, 7 months ago (2016-05-19 16:12:17 UTC) #4
Moe
https://codereview.chromium.org/1995933003/diff/1/chrome/browser/resources/md_user_manager/create_profile.html File chrome/browser/resources/md_user_manager/create_profile.html (right): https://codereview.chromium.org/1995933003/diff/1/chrome/browser/resources/md_user_manager/create_profile.html#newcode131 chrome/browser/resources/md_user_manager/create_profile.html:131: } On 2016/05/19 16:12:17, michaelpg wrote: > ; Done.
4 years, 7 months ago (2016-05-19 17:25:04 UTC) #5
michaelpg
lgtm
4 years, 7 months ago (2016-05-20 00:45:30 UTC) #6
Moe
On 2016/05/20 00:45:30, michaelpg wrote: > lgtm Thank you.
4 years, 7 months ago (2016-05-20 12:58:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995933003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995933003/20001
4 years, 7 months ago (2016-05-20 12:59:00 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 13:30:48 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 13:32:11 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3f03e9c251f1751a1298830fc1187c8d816055f7
Cr-Commit-Position: refs/heads/master@{#395063}

Powered by Google App Engine
This is Rietveld 408576698