Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 19959007: Objects can no longer be migrated or evacuated into large object space (Closed)

Created:
7 years, 5 months ago by Hannes Payer (out of office)
Modified:
7 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Objects can no longer be migrated or evacuated into large object space. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15848

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -32 lines) Patch
M src/mark-compact.cc View 1 2 chunks +20 lines, -31 lines 0 comments Download
M src/spaces.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
7 years, 5 months ago (2013-07-24 08:23:25 UTC) #1
Michael Starzinger
LGTM with a nit. The CL description is a bit misleading though. How about "Objects ...
7 years, 5 months ago (2013-07-24 08:40:08 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/19959007/diff/2001/src/spaces.h File src/spaces.h (right): https://codereview.chromium.org/19959007/diff/2001/src/spaces.h#newcode785 src/spaces.h:785: // are allocated in large object space and are ...
7 years, 5 months ago (2013-07-24 08:49:52 UTC) #3
Hannes Payer (out of office)
7 years, 5 months ago (2013-07-24 08:50:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r15848 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698